Bug 1538560

Or, use .orphan or .orphaned or whatever we are using for records where we could not find the namespace.  It is the same problem - we are attempting to process a record and we do not know what the namespace is.

(In reply to Rich Megginson from comment #1)
> Or, use .orphan or .orphaned or whatever we are using for records where we
> could not find the namespace.  It is the same problem - we are attempting to
> process a record and we do not know what the namespace is.

Could it be possible to have '.' for the namespace/project name?  Just replacing mux-undefined with .orphaned did not work...  Is it ok without '.'?

============================================================================
TASK [openshift_logging_mux : Add mux namespaces] ******************************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_logging_mux/tasks/main.yaml:22
0

<localhost> EXEC /bin/sh -c 'sudo -H -S -n -u root /bin/sh -c '"'"'echo BECOME-SUCCESS-alyossphfguzxwqsgoojjbvzflsmpbzy; /usr/bin/python /home/origin/.ansible/tmp/ansible-tmp-1522862486.42-161394758859912/oc_project.py; rm -rf "/home/origin/.ansible/tmp/ansible-tmp-1522862486.42-161394758859912/" > /dev/null 2>&1'"'"' && sleep 0'
The full traceback is:
  File "/tmp/ansible_bPRBHR/ansible_module_oc_project.py", line 47, in <module>
    import ruamel.yaml as yaml
failed: [localhost] (item=.orphaned) => {
    "changed": false, 
    "generated_timestamp": "2018-04-04 17:21:27.471423", 
    "invocation": {
        "module_args": {
            "admin": null, 
            "admin_role": "admin", 
            "debug": false, 
            "description": null, 
            "display_name": null, 
            "kubeconfig": "/etc/origin/master/admin.kubeconfig", 
            "name": ".orphaned", 
            "node_selector": [
                ""
            ], 
            "state": "present"
        }
    }, 
    "item": ".orphaned", 
    "msg": {
        "cmd": "/bin/oc adm new-project .orphaned --admin-role=admin --node-selector=", 
        "results": {}, 
        "returncode": 1, 
        "stderr": "The Project \".orphaned\" is invalid: metadata.name: Invalid value: \".orphaned\": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')\n", 
        "stdout": ""
    }

Right - .orphaned is not a legal namespace/project name.  It works as an index prefix just like .operations (also not a legal namespace/project name).

I think the way it should work is this - in openshift-ansible:

Remove openshift_logging_mux_default_namespaces

Add a warning to roles/openshift_logging_mux/tasks/main.yaml to say that openshift_logging_mux_default_namespaces is not supported and to use openshift_logging_mux_namespaces instead.

Change any docs in openshift-ansible that refer to openshift_logging_mux_default_namespaces to say that openshift_logging_mux_default_namespaces is not supported and to use openshift_logging_mux_namespaces instead.  Also say that 

In origin-aggregated-logging:

change "mux-undefined" to ".orphaned" - including docs
if there are any tests which create project "mux-undefined" just remove that project checking and creation

I'm a bit confused...

If I pass this [1] to ansible-playbook, it fails with the same error of course...

"The Project \".orphaned\" is invalid: metadata.name: Invalid value: \".orphaned\": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')\n",

Then, how the system could know the "orphaned" namespace/project would be ".orphaned"???

[1] -e openshift_logging_mux_namespaces=.orphaned

Both are set to WIP.

https://github.com/openshift/origin-aggregated-logging/pull/1065
https://github.com/openshift/openshift-ansible/pull/7792

There is no ".orphaned" namespace/project, just like there is no ".operations" namespace/project.

Treat ".orphaned" the same way we treat ".operations" - it is used as a prefix of a full Elasticsearch index name.  Except that there may be some sort of dummy orphaned "namespace" id used in the index name - @jcantrill would know.

Per discussion on https://github.com/openshift/origin-aggregated-logging/pull/1065, resetting the target release to 3.10.0.

Commits pushed to master at https://github.com/openshift/origin-aggregated-logging

https://github.com/openshift/origin-aggregated-logging/commit/9e4a97ee4f60f43624b80821d48da8ad18f8a7f2
Bug 1538560 - [RFE]rename the project name mux-undefined

The logs which failed to associate with the namespace/project will be
indexed into the ES index file .orphaned.YYYY.MM.DD instead of the
project.mux-undefined.*.

In rewrite_tag_filter (input-post-forward-mux.conf), if mux_namespace_name
is .orphaned, we will skip the effort to get k8s_metadata.

https://github.com/openshift/origin-aggregated-logging/commit/fb557c73e6c78e978759b52eb8336c98afde589c
Merge pull request #1065 from nhosoi/bz1538560

Bug 1538560 - [RFE]rename the project name mux-undefined

Could someone please review this pr https://github.com/openshift/openshift-ansible/pull/7792 ?

(In reply to Noriko Hosoi from comment #10)
> Could someone please review this pr
> https://github.com/openshift/openshift-ansible/pull/7792 ?

Correction: pr/7792 is still WIP.

The openshift-ansible pr/7792 removes openshift_logging_mux_default_namespaces, but keeps openshift_logging_mux_namespaces.  Setting the variable [1] makes the logging deployment fail as follows [2].  We should say "openshift_logging_mux_namespaces is not supported" as well?

[1] -e openshift_logging_mux_namespaces=.myorphaned

[2] 
TASK [openshift_logging_mux : Add mux namespaces] ******************************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_logging_mux/tasks/main.yaml:224
Using module file /usr/share/ansible/openshift-ansible/roles/lib_openshift/library/oc_project.py
   ...
The full traceback is:
  File "/tmp/ansible_qBRqou/ansible_module_oc_project.py", line 47, in <module>
    import ruamel.yaml as yaml
failed: [localhost] (item=.myorphaned) => {
   ...
"stderr": "The Project \".myorphaned\" is invalid: metadata.name: Invalid value: \".myorphaned\": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')\n",

> We should say "openshift_logging_mux_namespaces is not supported" as well?

ovirt/rhv rely on this feature, so we must support it.

If you specify a namespace, it must be a valid OpenShift/Kubernetes namespace.

Sorry.  Please ignore #c11.  It was my mistake in my testing.  It just should not have included '.' in the namespace name.  I'm retesting it now...  (I think the current pr/7792 would be ok after all...)

The ci-tests of https://github.com/openshift/openshift-ansible/pull/7792 have passed.  I removed WIP from the pr.  Could someone please review the pr?
Thanks!

Commits pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/56f952d734ec521253182cf33e6ed0017835a05c
Bug 1538560 - [RFE]rename the project name mux-undefined

mux-undefined ==> .orphaned
Removing openshift_logging_mux_default_namespaces.

https://github.com/openshift/openshift-ansible/commit/dc50fd346096e07b78d691cd820549627536807e
Merge pull request #7792 from nhosoi/bz1538560

Bug 1538560 - [RFE]rename the project name mux-undefined

Commit pushed to master at https://github.com/openshift/origin-aggregated-logging

https://github.com/openshift/origin-aggregated-logging/commit/d71a51ae633509e4f1338e95eefe3d07cffb95a9
Bug 1538560 - [RFE]rename the project name mux-undefined

The logs which failed to associate with the namespace/project will be
indexed into the ES index file .orphaned.YYYY.MM.DD instead of the
project.mux-undefined.*.

In rewrite_tag_filter (input-post-forward-mux.conf), if mux_namespace_name
is .orphaned, we will skip the effort to get k8s_metadata.

Tested on logging-elasticsearch-v3.10.34-2 and logging-fluentd-v3.10.34-1.
There is no project named mux-undefined and logs which failed to associate with the namespace/project are indexed into the ES index file .orphaned.YYYY.MM.DD.

So move to verified.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2376