Bug 1538922

Summary: aggregatedlogging should report fluentd pod missing while running oc adm diagnostics aggregatedlogging
Product: OpenShift Container Platform Reporter: Anping Li <anli>
Component: ocAssignee: Jan Wozniak <jwozniak>
Status: CLOSED ERRATA QA Contact: Anping Li <anli>
Severity: high Docs Contact:
Priority: high    
Version: 3.9.0CC: aos-bugs, jcantril, jokerman, lmeyer, mfojtik, mmccomas, pruan, xtian
Target Milestone: ---Keywords: Regression, TestBlocker
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-28 14:23:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Anping Li 2018-01-26 06:54:07 UTC
Description of problem:
aggregatedlogging should report fluentd pod missing and fluentd daemonset missing

Version-Release number of selected component (if applicable):


How reproducible:
openshift:v3.9.0-0.24.0

Steps to Reproduce:
1. deploy logging
2. Unlabel all the nodes where fluentd get running on
    oc label nodes logging-infra-fluentd- --all
     
3. Diagnose aggregated logging
   oc adm diagnostics aggregatedlogging
4. delete  daemonset
   oc delete daemonset logging-fluentd
5. Diagnose aggregated logging
   oc adm diagnostics aggregatedlogging


Actual results:
Both step 3,  5 completed with no errors or warnings seen.

[root@host3-ha-master-1 ~]# oc adm diagnostics aggregatedlogging
[Note] Determining if client configuration exists for client/cluster diagnostics
Info:  Successfully read a client config file at '/root/.kube/config'
Info:  Using context for cluster-admin access: 'logging/192-168-1-223:8443/system:admin'

[Note] Running diagnostic: AggregatedLogging
       Description: Check aggregated logging integration for proper configuration
       
[Note] Summary of diagnostics execution (version v3.9.0-0.24.0):
[Note] Completed with no errors or warnings seen.


Expected results:
Step 3, report:   Fluentd daemonset is not selecting any of the node to run pod, please label it
properly
Step 5, report: Fluentd daemonset did not exist


Additional info:

Comment 1 Luke Meyer 2018-01-26 20:31:55 UTC
/cc jeff not sure when I'll get a chance to look at this -- could be due to recent diagnostics refactor though.

Comment 3 Anping Li 2018-01-30 06:03:58 UTC
@Luke @Michal diagnostics aggregatedlogging  doesn't report any logging errors. It is a test block of logging team.

Comment 4 Anping Li 2018-02-02 01:37:58 UTC
@Michal, The diagnostics aggregatedlogging won't work at all.  Shall we fix it in v3.9.0?

Comment 5 Jan Wozniak 2018-02-02 15:06:47 UTC
problem is with silently skipping missing loggingPublicURL

more here:
https://bugzilla.redhat.com/show_bug.cgi?id=1539211#c1

Comment 6 Jan Wozniak 2018-02-05 12:34:57 UTC
*** Bug 1539211 has been marked as a duplicate of this bug. ***

Comment 7 openshift-github-bot 2018-02-13 13:56:23 UTC
Commits pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/7e2706c307e14bba68538e8ad7f900ddfb4e4e9f
Bug 1538922 - Fix diagnostics for AggregatedLogging

The `AssetConfig` section with the `loggingPublicURL` is being removed from the
`masterConfig`, therefore, we need a different logic to obtain logging project
name.

Currently, no location can provide logging project nor `loggingPublicURL` so we
make an assumption that logging is deployed by default to 'openshift-logging'
with legacy fallback to 'logging'. Optionally user can override the behaior
with `--logging-project=[project]` flag.

https://github.com/openshift/origin/commit/a70f803dd0832fee0ca21836339bbf46c5a58173
Merge pull request #18437 from wozniakjan/bz1538922/diagnostics/aggregatedlogging

Automatic merge from submit-queue (batch tested with PRs 18437, 18546, 18550, 18579).

Bug 1538922 - Fix diagnostics for AggregatedLogging

The `AssetConfig` section with the `loggingPublicURL` is being removed from the `masterConfig`, therefore, we need a different logic to obtain logging project name.

Currently, no location can provide logging project nor `loggingPublicURL` so we make an assumption that logging is deployed by default to 'openshift-logging' with legacy fallback to 'logging'. Optionally user can override the behaior with `--logging-project=[project]` flag.

Comment 9 Jan Wozniak 2018-02-21 07:41:22 UTC
Anping Li, please keep in mind you may stumble upon diagnostics reporting false negative - fluentd SA not being among cluster-readers. There is a pending fix for that as well but the original issue should be fixed

https://github.com/openshift/origin/pull/18641

Comment 10 Anping Li 2018-02-22 07:00:15 UTC
Verified and pass on oc v3.9.0-0.47.0.

Comment 13 errata-xmlrpc 2018-03-28 14:23:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489