Bug 1538940

Summary: "execute" button during configuration while deploying HE via cockpit based ansible deployment is confusing.
Product: [oVirt] cockpit-ovirt Reporter: Yihui Zhao <yzhao>
Component: Hosted EngineAssignee: Phillip Bailey <phbailey>
Status: CLOSED CURRENTRELEASE QA Contact: Yihui Zhao <yzhao>
Severity: high Docs Contact:
Priority: unspecified    
Version: ---CC: bugs, cshao, huzhao, lveyde, phbailey, qiyuan, rbarry, sbonazzo, weiwang, yaniwang, ycui, ylavi, yzhao
Target Milestone: ovirt-4.2.2Flags: rule-engine: ovirt-4.2+
cshao: testing_ack+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.17-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-29 10:58:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
button.png none

Description Yihui Zhao 2018-01-26 08:12:04 UTC
Created attachment 1386496 [details]
button.png

Description of problem: 

Should not use the "execute" button during configuration while deploying HE  via cockpit based ansible deployment. It will produce a misunderstanding for user.

Version-Release number of selected component (if applicable): 
cockpit-ws-157-1.el7.x86_64
cockpit-bridge-157-1.el7.x86_64
cockpit-storaged-157-1.el7.noarch
cockpit-dashboard-157-1.el7.x86_64
cockpit-157-1.el7.x86_64
cockpit-ovirt-dashboard-0.11.5-0.1.el7ev.noarch
cockpit-system-157-1.el7.noarch
ovirt-hosted-engine-setup-2.2.8-1.el7ev.noarch
ovirt-hosted-engine-ha-2.2.4-1.el7ev.noarch
rhvm-appliance-4.2-20171219.0.el7.noarch
rhvh-4.2.1.2-0.20180125.0+1

How reproducible: 
100% 


Steps to Reproduce: 
1. Clean install RHVH4.2.1 (rhvh-4.2.1.2-0.20180125.0+1) with ks
2. Deploy HE via cockpit based ansible deployment


Actual results: 
After step2, during the configuration, the "execute" button will produce a misunderstanding for the user.

Expected results: 


Additional info: 
Suggest to provide the "next" button to switch to the next page .

Comment 1 Yaniv Lavi 2018-02-14 13:34:06 UTC
Is this still relevant? If not, can you please close?

Comment 2 Phillip Bailey 2018-02-19 13:36:08 UTC
> Should not use the "execute" button during configuration while deploying HE 
> via cockpit based ansible deployment. It will produce a misunderstanding for
> user.
>
> Additional info: 
> Suggest to provide the "next" button to switch to the next page.

It's possible we should use a different word than "Execute", but "Next" would imply to the user that they will simply be moving to the next major step, which isn't true. Non-trivial activity occurs at the end of each major step, which is what the wording on the button is intended to indicate to the user. If the execution for that step is successful, the "Next" button is displayed, indicating to the user that it's safe to move on to the next major step.

I'm open to wording suggestions for the button, but "Next" isn't the correct choice, in my opinion. If no other suggestions are presented, I recommend closing this.

Comment 3 Ryan Barry 2018-02-19 15:12:21 UTC
How about "Continue"?

Comment 4 Phillip Bailey 2018-02-19 15:20:36 UTC
(In reply to Ryan Barry from comment #3)
> How about "Continue"?

I think "Continue" has the same problem as "Next" in that it doesn't indicate that something more than moving to the next step is going to happen upon clicking it. A couple of alternatives off the top of my head are: 

1. Put an info message in the preview screen explaining what will happen
2. Move the button inside of the preview screen and disable the "Next" button until execution has completed

Comment 5 Ryan Barry 2018-02-19 19:35:24 UTC
To me, at least, "Next" implies some immediacy, where "continue" and "proceed" carry the subtext that this is a process.

But this is nitpicky. Windows installer packages and Anaconda have used "next" for years, and it's something users are familiar with. They also don't expect an immediate return

Comment 6 Phillip Bailey 2018-02-19 20:17:48 UTC
(In reply to Ryan Barry from comment #5)
> To me, at least, "Next" implies some immediacy, where "continue" and
> "proceed" carry the subtext that this is a process.

I suppose. I like "proceed" better than continue.

> 
> But this is nitpicky. Windows installer packages and Anaconda have used
> "next" for years, and it's something users are familiar with. They also
> don't expect an immediate return

I don't know that I agree with the user expectation, but I'll concede as I agree that the whole issue is nitpicky.

Comment 7 Yihui Zhao 2018-02-27 01:41:55 UTC
(In reply to Phillip Bailey from comment #2)
> > Should not use the "execute" button during configuration while deploying HE 
> > via cockpit based ansible deployment. It will produce a misunderstanding for
> > user.
> >
> > Additional info: 
> > Suggest to provide the "next" button to switch to the next page.
> 
> It's possible we should use a different word than "Execute", but "Next"
> would imply to the user that they will simply be moving to the next major
> step, which isn't true. Non-trivial activity occurs at the end of each major
> step, which is what the wording on the button is intended to indicate to the
> user. If the execution for that step is successful, the "Next" button is
> displayed, indicating to the user that it's safe to move on to the next
> major step.
> 
> I'm open to wording suggestions for the button, but "Next" isn't the correct
> choice, in my opinion. If no other suggestions are presented, I recommend
> closing this.

"Proceed" seems ok.

Comment 8 Yaniv Kaul 2018-03-12 18:14:25 UTC
Two patches are merged - what else is missing? Why is it in NEW state?

Comment 9 Phillip Bailey 2018-03-12 19:37:30 UTC
(In reply to Yaniv Kaul from comment #8)
> Two patches are merged - what else is missing? Why is it in NEW state?

The patches were pushed and merged today. I just hadn't gone back through the list of bugs to see what needed to be updated. Moving to MODIFIED now.

Comment 10 Yihui Zhao 2018-03-16 07:15:36 UTC
With cockpit-ovirt-0.11.17-1, it changes the "execute" button to "Prepare VM". It will tell the user the step is preparing a local VM , isn't confusing.

So, change the bug's status to verified.

Comment 11 Sandro Bonazzola 2018-03-29 10:58:20 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.