Bug 1538977
| Summary: | kabi-dw: Do not build with Address Sanitizer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | kabi-dw | Assignee: | Zamir SUN <sztsian> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jmarchan, skozina, sztsian, zsun |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-31 14:30:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1537488, 1538990 | ||
|
Description
Florian Weimer
2018-01-26 10:03:13 UTC
Hi Stanislav, I've filed a pull request to resolve this. Can you check if you are willing to merge it? https://github.com/skozina/kabi-dw/pull/4 And I also thought about disable asan for debug builds totally, and move asan support to a separate make target. In case you are interested in that way, it was still available here https://github.com/sztsian/kabi-dw/commit/3787e1650a59682ff2872fa27ae7822e96b8376d Jerome, Can you please take a look at Zamir's commits above and share your thoughts? I tend decline the pull request and disable asan for debug builds, ie. the other commit. Thanks! (In reply to Stanislav Kozina from comment #2) > Jerome, > > Can you please take a look at Zamir's commits above and share your thoughts? > I tend decline the pull request and disable asan for debug builds, ie. the > other commit. Thanks! Yes, I would go with that too: if libasan causes ABI stability trouble, it's probably safer to remove it from the debug build by default. Oh, sure. I will rebase the pull request to the other commit. Just updated the pull request to the commit which disabled asan. This is fixed in 0-0.5-20180130git545535a https://src.fedoraproject.org/rpms/kabi-dw/c/0462cec7aaab283a4446d5a9e7404213a51d3852?branch=master |