Bug 1539078

Summary: Review Request: cjose - C library implementing the Javascript Object Signing and Encryption (JOSE)
Product: [Fedora] Fedora Reporter: Patrick Uiterwijk <puiterwijk>
Component: Package ReviewAssignee: Kevin Fenzi <kevin>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: kevin, package-review
Target Milestone: ---Flags: kevin: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-02 14:48:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Patrick Uiterwijk 2018-01-26 15:19:33 UTC 
Spec URL: http://puiterwijk.fedorapeople.org//cjose.spec
SRPM URL: http://puiterwijk.fedorapeople.org//cjose-0.5.1-1.fc27.src.rpm

Description:
Implementation of JOSE for C/C++
Comment 1 Patrick Uiterwijk 2018-01-26 15:19:41 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=24469949
Comment 2 Kevin Fenzi 2018-01-26 15:29:04 UTC 
I'll review this. Look for a review in a few...
Comment 3 Kevin Fenzi 2018-01-26 15:55:04 UTC 
rpmlint says: 

cjose-debugsource.x86_64: W: no-documentation
cjose-devel.x86_64: W: only-non-binary-in-usr-lib
cjose-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

All of which can be ignored. 

The "gitrev" in the source0 url needs to be %{version} instead. You can fix that on import. 

License is ok and good. 

Package approved.
Comment 4 Patrick Uiterwijk 2018-01-26 16:24:07 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/cjose
Comment 5 Mattia Verga 2020-06-02 14:48:06 UTC 
This package was approved and imported in repositories, but this review ticket was never closed.
I'm closing it now.