Bug 1539276

Summary:	Review Request: rust-threadpool - Thread pool for running a number of jobs on a fixed set of worker threads
Product:	[Fedora] Fedora	Reporter:	Tomas Tomecek <ttomecek>
Component:	Package Review	Assignee:	Igor Gnatenko <ignatenko>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---	Flags:	ignatenko: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-14 17:29:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Tomecek 2018-01-27 12:25:38 UTC

Spec URL: https://ttomecek.fedorapeople.org/rust-threadpool.spec
SRPM URL: https://ttomecek.fedorapeople.org/rust-threadpool-1.7.1-1.fc28.src.rpm
Description: A thread pool for running a number of jobs on a fixed set of worker threads.

This package contains library source intended for building other packages
which use %{crate} from crates.io.
Fedora Account System Username: ttomecek

Comment 1 Igor Gnatenko 2018-01-28 07:27:42 UTC

> Summary:        A thread pool for running a number of jobs on a fixed set of worker threads.
summary should not end with ".", also remove "A " (but keep it in description).

> %license LICENSE-MIT
> %license LICENSE-APACHE
nitpick: better to have them in one line.

Also you need to add:
* %doc README.md CHANGES.md
* %exclude %{cargo_registry}/%{crate}-%{version}/appveyor.yml

Apart from above, looks good.

Comment 2 Tomas Tomecek 2018-02-01 14:42:59 UTC

Thanks Igor! Good suggestions.

Spec URL: https://ttomecek.fedorapeople.org/rust-threadpool.spec
SRPM URL: https://ttomecek.fedorapeople.org/rust-threadpool-1.7.1-2.fc28.src.rpmthttps://crates.io/crates/threadpool

Comment 3 Igor Gnatenko 2018-02-02 07:56:50 UTC

LGTM now

Comment 4 Gwyn Ciesla 2018-02-05 12:25:30 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-threadpool. You may commit to the branch "f27" in about 10 minutes.

Comment 5 Fedora Update System 2018-02-05 13:33:26 UTC

rust-threadpool-1.7.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8cf4ad15b8

Comment 6 Fedora Update System 2018-02-05 17:08:37 UTC

rust-threadpool-1.7.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8cf4ad15b8

Comment 7 Fedora Update System 2018-02-14 17:29:19 UTC

rust-threadpool-1.7.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.