Bug 1539395

Summary: virt-customize segfaults after upgrading to 1.37.35-3
Product: [Fedora] Fedora Reporter: David Hill <dhill>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: urgent    
Version: rawhideCC: dhill, mgoldman, rjones
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 1:1.37.36-1.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-30 14:19:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
debug.stdout none

Description David Hill 2018-01-28 15:26:26 UTC
Description of problem:

virt-customize segfaults after upgrading to 1.37.35-3

Customizing image                                           create_undercloud.sh: line 381: 31882 Segmentation fault      sudo virt-customize -v -a $jenkinspath/VMs/${vmname}.qcow2 $uploadcmd iptables:/etc/sysconfig/ $uploadcmd customize.service:/etc/systemd/system/ $uploadcmd tmp/S01customize:/etc/rc.d/rc3.d/ $uploadcmd S01loader:/etc/rc.d/rc3.d/ --root-password password:$rootpasswd --link /etc/systemd/system/customize.service:/etc/systemd/system/multi-user.target.wants/customize.service $uploadcmd cloud.cfg:/etc/cloud 2>> $stderr >> $stdout


libguestfs-tools-c-1.37.35-3.fc28.x86_64
libguestfs-1.37.35-3.fc28.x86_64
libguestfs-tools-1.37.35-3.fc28.noarch
libguestfs-xfs-1.37.35-3.fc28.x86_64



Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Update to latest version
2. Try customizing an image
3.

Actual results:
Segfaults

Expected results:
Complete successfully

Additional info:

Comment 1 David Hill 2018-01-28 15:28:56 UTC
Created attachment 1387251 [details]
debug.stdout

Comment 2 David Hill 2018-01-28 15:56:55 UTC
Found 1:1.37.36-1.fc28 and it solves the problem.

Comment 3 Richard W.M. Jones 2018-01-28 16:05:42 UTC
I'm going to guess this happens because glibc dropped crypt(3)
from libc.so.6.  Since virt-customize can link to and call this
function it caused a crash somehow.  The upstream fix was:

https://github.com/libguestfs/libguestfs/commit/b0df5f26fec067928896b66089040cf785bcf070

Comment 4 Richard W.M. Jones 2018-01-30 12:11:50 UTC
I looked into this a bit deeper and in fact reproduced the problem.
The fix is:
https://www.redhat.com/archives/libguestfs/2018-January/msg00273.html

Comment 5 Richard W.M. Jones 2018-01-30 14:19:30 UTC
Upstream fix added:
https://github.com/libguestfs/libguestfs/commit/0c3d2d9430e985a901af8e05da6d0a6b9f59bd12