Bug 1539614

Summary: Tagging broken in Datastores and My Services page
Product: Red Hat CloudForms Management Engine Reporter: Hilda Stastna <hstastna>
Component: UI - OPSAssignee: Hilda Stastna <hstastna>
Status: CLOSED CURRENTRELEASE QA Contact: Jad Haj Yahya <jhajyahy>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, hkataria, lavenel, mpovolny, obarenbo
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1552879 (view as bug list) Environment:
Last Closed: 2019-02-11 14:03:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1552879    
Attachments:
Description Flags
Error in advanced_search.rb none

Description Hilda Stastna 2018-01-29 10:36:31 UTC
Created attachment 1387678 [details]
Error in advanced_search.rb

Description of problem:
Tagging a datastore or a datastore cluster leads to a 500 in advanced search.

Version-Release number of selected component (if applicable):
5.9.

How reproducible:
100%

Steps to Reproduce:
1. Go to Compute -> Infrastructure -> Datastores
2. Open Advanced Search and load AND apply some filter from there, or create some new expression and apply it OR click on some filter from Global/My Filters in accordion.
3. Clear the applied filter
4. Try to tag some datastore(s) from its details page or by checking the checkbox(es) from All Datastores (or datastore clusters) and clicking on Edit Tags under Configuration.

Actual results:
Tagging a datastore or a datastore cluster leads to a 500 in advanced search.

Expected results:
No error when entering tagging page for datastore or a datastore cluster.

Additional info:
The step 2 is necessary to reproduce this bug. I was not able to reproduce the bug without this step. It looks like that some variable is set to nil during this process, and this is crucial for some other actions, like tagging.
The error leads to advanced_search.rb.

Comment 3 Hilda Stastna 2018-01-29 17:10:30 UTC
Note that the same problem occurs in Services -> My Services page.

Comment 4 CFME Bot 2018-02-02 13:14:44 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/42f8849a0e994e16343bed7defb0b4d34014b768

commit 42f8849a0e994e16343bed7defb0b4d34014b768
Author:     Hilda Stastna <hstastna>
AuthorDate: Mon Jan 29 16:10:45 2018 +0100
Commit:     Hilda Stastna <hstastna>
CommitDate: Thu Feb 1 19:10:43 2018 +0100

    Fix broken tagging in Datastores and My Services
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539614
    
    Fix broken tagging in Compute -> Infrastructure -> Datastores which breaks
    after working with filters or Advanced search because of wrong setting of
    @edit. The same for My Services page.

 app/controllers/application_controller/advanced_search.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)