Bug 1539750

Summary: [RFE] Naming Runs Before Parsed Dialog: Dialog Options missing via prov.get_tags or prov.get_option
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: AutomateAssignee: Greg McCullough <gmccullo>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: high Docs Contact:
Priority: high    
Version: 5.7.0CC: brant.evans, cpelland, jcutter, jhardy, mkanoor, obarenbo, simaishi, smallamp, tfitzger
Target Milestone: GAKeywords: FutureFeature
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.0.19 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1455002 Environment:
Last Closed: 2018-03-06 15:28:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1455002    
Bug Blocks:    

Comment 2 CFME Bot 2018-01-29 14:47:59 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/e72d1155b356a77c1256dcdd34e4cf37884413f9

commit e72d1155b356a77c1256dcdd34e4cf37884413f9
Author:     Brandon Dunne <brandondunne>
AuthorDate: Fri Jan 26 17:23:11 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Jan 29 09:42:59 2018 -0500

    Merge pull request #16897 from gmcculloug/provision_vm_name
    
    Refactor VM naming method in provisioning task to support call from automate
    (cherry picked from commit ee6cb2d7ffab0853db0376aa5b4d31e20410c5b8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1539750

 app/models/miq_provision.rb          | 15 +++++++++-----
 app/models/miq_provision/automate.rb | 14 +++++++++++++
 app/models/miq_provision/naming.rb   |  8 +-------
 app/models/miq_provision_request.rb  |  6 +++++-
 spec/models/miq_provision_spec.rb    | 39 ++++++++++++++++++++++++++++++++----
 5 files changed, 65 insertions(+), 17 deletions(-)

Comment 3 CFME Bot 2018-01-29 14:53:12 UTC
New commit detected on ManageIQ/manageiq-automation_engine/gaprindashvili:
https://github.com/ManageIQ/manageiq-automation_engine/commit/6e079c32e2b9d7cba413cfd2aa7b8be7066a239c

commit 6e079c32e2b9d7cba413cfd2aa7b8be7066a239c
Author:     Oleg Barenboim <chessbyte>
AuthorDate: Sat Jan 27 09:40:54 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Jan 29 09:45:19 2018 -0500

    Merge pull request #153 from gmcculloug/miq_provision_update_vm_name
    
    Support calling update_vm_name for miq_provision service models
    (cherry picked from commit cf31df0a593f2f650169101fd4569e7ce7bd3c60)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539750

 lib/miq_automation_engine/service_models/miq_ae_service_miq_provision.rb | 1 +
 1 file changed, 1 insertion(+)

Comment 4 CFME Bot 2018-02-05 17:26:58 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/7f3a211145eb28713cb941b6ae2927e58c72c1c6

commit 7f3a211145eb28713cb941b6ae2927e58c72c1c6
Author:     Brandon Dunne <brandondunne>
AuthorDate: Mon Feb 5 11:20:16 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Feb 5 12:25:23 2018 -0500

    Merge pull request #16949 from gmcculloug/provision_vm_update_name_service
    
    Follow up to update_vm_name for Service template provisioning
    (cherry picked from commit cdb1271d6d4f51d0f55253676f9170b2f7a1bbd0)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1539750

 app/models/miq_provision.rb       |  2 +-
 spec/models/miq_provision_spec.rb | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

Comment 5 Shveta 2018-02-13 05:38:28 UTC
Fixed .
Verified in 5.9.0.20.20180206200727_d1873b9 .

VM name was updated .