Bug 1540264

Summary:	libsmbios: Build flags injection only partially successful
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	libsmbios	Assignee:	Michael E Brown <mebrown>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	cz172638, karsten, mebrown, praveenkpaladugu, srinivas_g_gowda
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libsmbios-2.4.1-2.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-27 04:06:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Description Florian Weimer 2018-01-30 16:23:26 UTC

The build flags from redhat-rpm-config were only partly injected into the build of libsmbios-2.3.3-2.fc28.  Here, CFLAGS is missing:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I./out/include -I./out/include -I../src/include -DLIBSMBIOS_LOCALEDIR=\"/usr/share/locale\" -I../src/libsmbios_c/common -Wall -fPIC -fvisibility=hidden -Werror -c ../src/libsmbios_c/token/token.c -o src/libsmbios_c/token/out_libsmbios_c_la-token.o >/dev/null 2>&1

And this appears to lack parts of LDFLAGS (the -specs=/usr/lib/rpm/redhat/redhat-hardened-ld flag is missing):

libtool: link: gcc -shared  -fPIC -DPIC  src/libsmbios_c/common/.libs/out_libsmbios_c_la-common.o src/libsmbios_c/common/.libs/out_libsmbios_c_la-strlcpy.o src/libsmbios_c/common/.libs/out_libsmbios_c_la-strlcat.o src/libsmbios_c/cmos/.libs/out_libsmbios_c_la-cmos.o src/libsmbios_c/cmos/.libs/out_libsmbios_c_la-cmos_ut.o src/libsmbios_c/cmos/.libs/out_libsmbios_c_la-cmos_obj.o src/libsmbios_c/memory/.libs/out_libsmbios_c_la-memory_obj.o src/libsmbios_c/memory/.libs/out_libsmbios_c_la-memory.o src/libsmbios_c/smbios/.libs/out_libsmbios_c_la-smbios.o src/libsmbios_c/smbios/.libs/out_libsmbios_c_la-smbios_fixups.o src/libsmbios_c/smbios/.libs/out_libsmbios_c_la-smbios_obj.o src/libsmbios_c/smi/.libs/out_libsmbios_c_la-smi.o src/libsmbios_c/smi/.libs/out_libsmbios_c_la-smi_obj.o src/libsmbios_c/smi/.libs/out_libsmbios_c_la-smi_password.o src/libsmbios_c/system_info/.libs/out_libsmbios_c_la-id_byte.o src/libsmbios_c/system_info/.libs/out_libsmbios_c_la-asset_tag.o src/libsmbios_c/system_info/.libs/out_libsmbios_c_la-service_tag.o src/libsmbios_c/system_info/.libs/out_libsmbios_c_la-property_tag.o src/libsmbios_c/system_info/.libs/out_libsmbios_c_la-system_info.o src/libsmbios_c/system_info/.libs/out_libsmbios_c_la-state_byte.o src/libsmbios_c/system_info/.libs/out_libsmbios_c_la-up_flag.o src/libsmbios_c/token/.libs/out_libsmbios_c_la-checksum.o src/libsmbios_c/token/.libs/out_libsmbios_c_la-token.o src/libsmbios_c/token/.libs/out_libsmbios_c_la-token_obj.o src/libsmbios_c/token/.libs/out_libsmbios_c_la-token_d4.o src/libsmbios_c/token/.libs/out_libsmbios_c_la-token_da.o src/libsmbios_c/cmos/.libs/out_libsmbios_c_la-cmos_linux.o src/libsmbios_c/memory/.libs/out_libsmbios_c_la-memory_linux.o src/libsmbios_c/smbios/.libs/out_libsmbios_c_la-smbios_linux.o src/libsmbios_c/smi/.libs/out_libsmbios_c_la-smi_linux.o   -L./out/  -Wl,--no-undefined -Wl,-as-needed -Wl,-z -Wl,relro   -Wl,-soname -Wl,libsmbios_c.so.2 -o out/.libs/libsmbios_c.so.2.2.1

Comment 1 Fedora End Of Life 2018-02-20 15:36:24 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Karsten Hopp 2018-04-18 10:14:29 UTC

A simple rebuild with the latest F28 fixes this. 
https://koji.fedoraproject.org/koji/taskinfo?taskID=26436209

-spec still gets stripped by libtool when shared libraries get linked, but '-Wl,relro -Wl,-z -Wl,now' will now be used.

Comment 3 Fedora Update System 2018-04-18 10:21:35 UTC

libsmbios-2.4.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ccd133d400

Comment 4 Fedora Update System 2018-04-18 16:21:19 UTC

libsmbios-2.4.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ccd133d400

Comment 5 Fedora Update System 2018-04-27 04:06:32 UTC

libsmbios-2.4.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.