Bug 1540268

Summary:	tbb: libirml.so.1 not built with the official build flags
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	tbb	Assignee:	Jiri Kastner <cz172638>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	cz172638, loganjerry, me
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-06 04:29:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Description Florian Weimer 2018-01-30 16:35:16 UTC

For tbb-2018.2-3.fc28, the injection of the build flags from redhat-rpm-config into the build was only partially successful.

This appears to be part of libirm, but does not use the official CFLAGS:

g++ -c -MMD  -DDO_ITT_NOTIFY=0 -g -O2 -DUSE_PTHREAD -m64 -mrtm -Wall   -Wno-parentheses -Wno-non-virtual-dtor -DTBB_USE_THREADING_TOOLS=0 -D__TBB_RML_STATIC=1 -D__TBB_NO_IMPLICIT_LINKAGE=1 -fPIC -flifetime-dse=1 -I../../src -I../../src/rml/include -I../../include -I../../src/rml/include -I. ipc_utils.cpp

And for the final link, LDFLAGS injection is missing:

g++ -fPIC -o libirml.so.1 ipc_server.o ipc_utils.o cache_aligned_allocator_rml.o dynamic_link_rml.o tbb_misc_rml.o tbb_misc_ex_rml.o   -ldl -lpthread -lrt -ldl -shared -Wl,-soname=libirml.so.1 -m64

Other parts of the tbb build process do not have this problem.

Comment 1 Jerry James 2018-01-31 05:08:44 UTC

Thanks for the bug report, Florian.  The addition of libirml was a kind of last-minute thing, when I discovered that the python interface had been linked with it, but the library itself was not installed by upstream's Makefile.  I obviously did not scrutinize it carefully enough.

A fixed build is heading for Rawhide shortly.

Comment 2 Jerry James 2018-02-06 04:29:36 UTC

Fixed in Rawhide.