Bug 1540686
| Summary: | [Regression] Backup/restore failing on appliances using pglogical | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | luke couzens <lcouzens> | |
| Component: | Appliance | Assignee: | Nick Carboni <ncarboni> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | luke couzens <lcouzens> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.9.0 | CC: | abellott, cpelland, dajohnso, ncarboni, obarenbo | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | black:appliance | |||
| Fixed In Version: | 5.10.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1553903 (view as bug list) | Environment: | ||
| Last Closed: | 2019-02-11 13:58:40 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1553903 | |||
|
Description
luke couzens
2018-01-31 18:30:01 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/898b63d6aa274ef7d472e391329b366d8f057908 commit 898b63d6aa274ef7d472e391329b366d8f057908 Author: Nick Carboni <ncarboni> AuthorDate: Fri Feb 2 10:11:30 2018 -0500 Commit: Nick Carboni <ncarboni> CommitDate: Mon Feb 12 14:20:45 2018 -0500 Check for restore error cases in EvmDatabaseOps This allows us to do more of the processing using existing code rather than the current implementation which does the checks in different places/repos and does a lot of shelling out to psql rather than using a real database connection. This also makes the error cases more explicit which fixes an issue where a user could not restore a pg_dump backup when pglogical was running. https://bugzilla.redhat.com/show_bug.cgi?id=1540686 lib/evm_database_ops.rb | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) New commit detected on ManageIQ/manageiq-gems-pending/master: https://github.com/ManageIQ/manageiq-gems-pending/commit/d8c0f087105ac5a271f1813029e36f2e97758ba9 commit d8c0f087105ac5a271f1813029e36f2e97758ba9 Author: Nick Carboni <ncarboni> AuthorDate: Thu Feb 1 18:03:20 2018 -0500 Commit: Nick Carboni <ncarboni> CommitDate: Thu Feb 1 18:03:20 2018 -0500 Dont mess with pglogical from PostgresAdmin We will handle this in the main app rake task before we even get to this class to do the restore. This will be cleaner as we can use all the tooling we have built up around the extension there rather than shelling out to psql from here https://bugzilla.redhat.com/show_bug.cgi?id=1540686 lib/gems/pending/util/postgres_admin.rb | 32 -------------------------------- 1 file changed, 32 deletions(-) New commit detected on ManageIQ/manageiq-appliance_console/master: https://github.com/ManageIQ/manageiq-appliance_console/commit/c7a06452334d3d476ef57a7c811d1909e23ad261 commit c7a06452334d3d476ef57a7c811d1909e23ad261 Author: Nick Carboni <ncarboni> AuthorDate: Thu Feb 1 18:01:39 2018 -0500 Commit: Nick Carboni <ncarboni> CommitDate: Thu Feb 1 18:01:39 2018 -0500 Remove database restore connection checking This is going to be done in the app rake task code before the restore gets run. This allows us to use the AR model we have around pg_stat_activity to check the connections rather than shelling out to a rake task from here https://bugzilla.redhat.com/show_bug.cgi?id=1540686 bin/appliance_console | 8 -------- 1 file changed, 8 deletions(-) This is just waiting on a new version of the console to be released. Then the changes will be complete when we can update the version we use on the appliance. New commit detected on ManageIQ/manageiq-appliance/master: https://github.com/ManageIQ/manageiq-appliance/commit/12569df44a11cca89d177a45b91d8b71491b2e3d commit 12569df44a11cca89d177a45b91d8b71491b2e3d Author: Nick Carboni <ncarboni> AuthorDate: Fri Mar 9 14:32:28 2018 -0500 Commit: Nick Carboni <ncarboni> CommitDate: Fri Mar 9 14:32:28 2018 -0500 Use version 2 of appliance console Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1540686 manageiq-appliance-dependencies.rb | 4 +- 1 file changed, 2 insertions(+), 2 deletions(-) Verified in 5.10 *** Bug 1559451 has been marked as a duplicate of this bug. *** New commit detected on ManageIQ/manageiq-appliance_console/master: https://github.com/ManageIQ/manageiq-appliance_console/commit/6bedfebbe83aa6c114d434619bbf38c707d29822 commit 6bedfebbe83aa6c114d434619bbf38c707d29822 Author: Nick Carboni <ncarboni> AuthorDate: Thu Feb 1 23:03:20 2018 +0000 Commit: Nick LaMuro <nicklamuro> CommitDate: Tue Mar 16 19:25:16 2021 +0000 Dont mess with pglogical from PostgresAdmin We will handle this in the main app rake task before we even get to this class to do the restore. This will be cleaner as we can use all the tooling we have built up around the extension there rather than shelling out to psql from here https://bugzilla.redhat.com/show_bug.cgi?id=1540686 (transferred from ManageIQ/manageiq-gems-pending@d8c0f087105ac5a271f1813029e36f2e97758ba9) lib/manageiq/appliance_console/postgres_admin.rb | 32 - 1 file changed, 32 deletions(-) |