Bug 1540689

Summary:	[Embedded Ansible] Service UI - MyServices - Credentials do not show(Shows default CFME Creds)
Product:	Red Hat CloudForms Management Engine	Reporter:	Kedar Kulkarni <kkulkarn>
Component:	UI - Service	Assignee:	Allen W <awight>
Status:	CLOSED DUPLICATE	QA Contact:	Kedar Kulkarni <kkulkarn>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	bascar, cpelland, dclarizi, gmccullo, lavenel, obarenbo, simaishi
Target Milestone:	GA	Flags:	kkulkarn: automate_bug+
Target Release:	cfme-future
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ansible_embed
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-09 14:04:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Kedar Kulkarni 2018-01-31 18:47:32 UTC

Description of problem:
Even if you select Machine Credentials or anything else for ansible playbook service, in the Service UI, it shows "CFME Default Credential" and also does not show Cloud Credentials. 

Version-Release number of selected component (if applicable):
5.8.3.2

How reproducible:
100%

Steps to Reproduce:
1.Enable Embedded Ansible 
2.Add Ansible Repo
3.Add Machine and Cloud credentials
4.Create catalog item using this repo and cloud creds, leave machine creds to defaul CFME Creds 
5.Order the service by selecting "Machine" creds from the credentials dropdown 
5.Observe service details in SSUI

Actual results:
Service UI service details still showing CFME Default Creds and No Cloud Creds

Expected results:
Service UI service details should show Machine and Cloud creds

Additional info:

Comment 2 Kedar Kulkarni 2018-01-31 20:03:30 UTC

Checked against      Outcome
5.9.0.18 -           SSUI does not show correct machine credentials
5.9.0.19 -           SSUI does not show correct machine credentials

5.8.2.3 -            SSUI does not show correct machine credentials as well as 
                     does not show any Cloud Credentials

Comment 3 Greg McCullough 2018-02-01 15:22:51 UTC

Kedar - Can you provide a screenshot of the 5.9 UI and is there an appliance available that reproduces this issue that we can review?

Comment 5 Bill Wei 2018-02-01 19:10:05 UTC

The UI gets the credentials from service object. In its options there are two places for credentials - one from config_info, the other from dialog.
config_info contains the definition of the original catalog item
dialog contains overridden values at service ordering time.

UI should use credentials from the dialog, and fall back the credentials from config_info only there is no value for credentials in dialog.

Only machine credential can be overridden. Therefore UI should take the value for machine credential first from dialog, then if missing fall back to config_info.

Cloud credentials can be only in config_info.

The bug reported is because UI only read values from config_info.

Example of a service object:

options:
  config_info:
    provision:
      credential_id: 6
      cloud_credential_id: 8
  dialog:
    dialog_credential: 7

The correct result should be machine_credential = 7, cloud_credential = 8.

The above rule only applies to provision. Retirement should take values from config_info because there is no dialog for retirement.

Comment 6 Allen W 2018-04-03 13:35:25 UTC

Thanks for that guidance Bill! I think this bz is kinda a dup of https://bugzilla.redhat.com/show_bug.cgi?id=1557504

watcha think Dan?

Comment 7 Allen W 2018-04-03 20:59:58 UTC

Ok so we got a pr.. need to test it a bit to ensure its the right fix https://github.com/ManageIQ/manageiq-ui-service/pull/1417/files

Comment 8 Allen W 2018-04-05 15:58:59 UTC

And this pr was merged, since target is future, we can post this thing!

Comment 9 Satoe Imaishi 2018-04-09 14:04:07 UTC


*** This bug has been marked as a duplicate of bug 1557504 ***

Comment 10 Red Hat Bugzilla 2023-09-14 04:16:10 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days