Bug 1540855
| Summary: | [UI][RHOS] - remove Edit and Delete actions when in the SDN list view | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Pavol Kotvan <pakotvan> | |
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavol Kotvan <pakotvan> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.8.0 | CC: | cpelland, dajohnso, dclarizi, hkataria, lavenel, maufart, mpovolny, obarenbo, pakotvan, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly | |
| Target Release: | 5.9.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ui:rhos | |||
| Fixed In Version: | 5.9.0.20 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1544488 (view as bug list) | Environment: | ||
| Last Closed: | 2018-03-06 15:08:36 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Bug | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | Openstack | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1544488 | |||
|
Comment 5
Dave Johnson
2018-02-01 16:08:52 UTC
Marek, what happened here is that the functionality was implemented for OpenStack. It works for OpenStack. But it was enabled for both the single-item case (with proper checking if the particular action supports given action) and also for the list of items case. In the list of items case no logic that would check the item type and support for the particular action was added. That means that when you have a mix of items e.g. OpenStack + EC2 the functionality is broken. The existing code crashes on EC2. To fix that we removed the buttons from the list case and left them just for the single-item case. Examples: https://github.com/ManageIQ/manageiq-ui-classic/pull/3349 https://github.com/ManageIQ/manageiq-ui-classic/pull/2234 To enable the buttons in the list requires implementing the missing checking of items. We (me and Ladas) decided not to do that because of how late in the release. This would not be about fixing bugs but about implementing missing functionality. Furthermore the code is ugly. It needs cleanup so that it can be worked with. I a going to PTO for a week I'll refer you to Ladas if further explanation is needed. I suggest against enabling the buttons for gaprindashvili. Seeing the level of cut-n-paste by the implementors of the problematic functionality I think that the core team needs to provide a generic way of checking the available actions for the list of items case. We can work on that but it's at least a sprint of work. I suggest closing this BZ as WONTFIX. |