Bug 1541458
Summary: | Changes to self-heal logic w.r.t. detecting of split-brains | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Ravishankar N <ravishankar> |
Component: | replicate | Assignee: | Ravishankar N <ravishankar> |
Status: | CLOSED EOL | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.13 | CC: | bugs, olim |
Target Milestone: | --- | Keywords: | Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | 1539358 | Environment: | |
Last Closed: | 2018-06-20 18:26:24 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1539358, 1542380, 1597123 | ||
Bug Blocks: | 1384983 |
Description
Ravishankar N
2018-02-02 15:59:45 UTC
REVIEW: https://review.gluster.org/19479 (afr: don't treat all cases all bricks being blamed as split-brain) posted (#1) for review on release-3.13 by Ravishankar N COMMIT: https://review.gluster.org/19479 committed in release-3.13 by "Shyamsundar Ranganathan" <srangana> with a commit message- afr: don't treat all cases all bricks being blamed as split-brain Problem: We currently don't have a roll-back/undoing of post-ops if quorum is not met. Though the FOP is still unwound with failure, the xattrs remain on the disk. Due to these partial post-ops and partial heals (healing only when 2 bricks are up), we can end up in split-brain purely from the afr xattrs point of view i.e each brick is blamed by atleast one of the others. These scenarios are hit when there is frequent connect/disconnect of the client/shd to the bricks while I/O or heal are in progress. Fix: Instead of undoing the post-op, pick a source based on the xattr values. If 2 bricks blame one, the blamed one must be treated as sink. If there is no majority, all are sources. Once we pick a source, self-heal will then do the heal instead of erroring out due to split-brain. Change-Id: I3d0224b883eb0945785ade0e9697a1c828aec0ae BUG: 1541458 Signed-off-by: Ravishankar N <ravishankar> (cherry picked from commit 0e6e8216823c2d9dafb81aae0f6ee3497c23d140) This bug reported is against a version of Gluster that is no longer maintained (or has been EOL'd). See https://www.gluster.org/release-schedule/ for the versions currently maintained. As a result this bug is being closed. If the bug persists on a maintained version of gluster or against the mainline gluster repository, request that it be reopened and the Version field be marked appropriately. |