Bug 1541768
| Summary: | Update operations INFO logging should contain info about the changed properties | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Elad <ebenahar> | ||||
| Component: | RFEs | Assignee: | Rob Young <royoung> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Gil Klein <gklein> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | --- | CC: | bugs, ebenahar, mperina, tnisan | ||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||
| Target Release: | --- | Flags: | rule-engine:
planning_ack?
rule-engine: devel_ack? rule-engine: testing_ack? |
||||
| Hardware: | x86_64 | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-02-08 14:00:58 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
I don't think I understand the problem here, what would you like to see, a dump of all the properties of the domain? Seems to me a bit overkill Also why is it a 10MB log spanning almost a week? Please trim the logs No, just the property that was updated, before and after the change. For example, I'd expect the log message pasted in the bug description to have something like "Domain Backup property changed from false to true" I find it quite overkill to log all the changes, is it done in any other of the update commands in the system? Actually no [1]. Modifying this bug to RFE for cross-system update operations logging [1] 2018-01-16 17:01:00,970+02 INFO [org.ovirt.engine.core.bll.UpdateVmCommand] (default task-9) [1b34fddd-302c-4441-a6da-d4a00deac422] Running command: UpdateVmCommand internal: false. Entities affected : ID: 6bc 635a4-25c1-4790-81b3-c4576eef0fb5 Type: VMAction group EDIT_VM_PROPERTIES with role type USER I don't see any reason why we should log all changed properties and their values, not to mention we don't have any easy way how to find out which properties were changed. Providing such information would required huge changes which would also affect performance. If you need that kind of information detail, please turn on SQL commands logging on PostgreSQL where you can find details about every database updates. |
Created attachment 1391006 [details] logs Description of problem: Updated storage domain, in this case, to be a backup domain. The parameter name (backup) is not logged in the logging message in engine.log (INFO log level). 2018-02-04 17:06:33,021+02 INFO [org.ovirt.engine.core.bll.storage.domain.UpdateStorageDomainCommand] (default task-5) [] Running command: UpdateStorageDomainCommand internal: false. Entities affected : ID: db01428b-6609-4599-8ca5-ce78fe5f4a74 Type: StorageAction group EDIT_STORAGE_DOMAIN_CONFIGURATION with role type ADMIN Version-Release number of selected component (if applicable): rhvm-4.2.1.4-0.1.el7.noarch How reproducible: Always