Bug 1542115

Summary: [Horizon] "Delete Volume on instance delete" is appearing twice if we boot instance from volume tab under horizon dashboard.
Product: Red Hat OpenStack Reporter: MD Sufiyan <msufiyan>
Component: python-django-horizonAssignee: Radomir Dopieralski <rdopiera>
Status: CLOSED ERRATA QA Contact: Eldar Weiss <eweiss>
Severity: low Docs Contact:
Priority: low    
Version: 11.0 (Ocata)CC: athomas, beth.white, chhu, flfuchs, mlehmann, mrunge, sclewis, srevivo, ukalifon
Target Milestone: Upstream M1Keywords: Triaged
Target Release: 15.0 (Stein)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-django-horizon-15.0.0-0.20190123153319.4a8d00d.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-09-21 11:15:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Double Button
none
Double button not predefined none

Description MD Sufiyan 2018-02-05 15:34:49 UTC
Created attachment 1391580 [details]
Double Button

Description of problem:

"Delete Volume on instance delete" is appearing twice if we boot instance from volume tab under horizon dashboard.

Version-Release number of selected component (if applicable):

OSP11
python-django-horizon-11.0.3-3.el7ost.noarch

How reproducible:

Everytime (for OSP10 and OSP11)

Steps to Reproduce:
1. Create a volume from image (eg : cirros)
2. Launch the instance from volume tab and select the volume as a source
3. "Delete Volume on instance delete" button will appear twice.

Actual results:

"Delete Volume on instance delete" is appears twice.

Sometimes the volume is not predefined, which should be always there otherwise the option to launch an instance from a volume makes no sense. After pressing F5 (refresh) the volume will be predefined.
The double button is always there.

Same works fine if we boot instance from horizon tab.

Expected results:

a) There should be one "Delete Volume on instance delete" button.
b) volume should alway be predefined we select volume as source.

Additional info:

This works fine in OSP12 version, issue seems to be in OSP10 and OSP11 version only.

Comment 1 MD Sufiyan 2018-02-05 15:35:47 UTC
Created attachment 1391581 [details]
Double button not predefined

Comment 2 Udi Kalifon 2018-03-28 13:20:49 UTC
Please check if it's not already fixed in the current release.

Comment 4 Radomir Dopieralski 2018-08-28 13:47:33 UTC
I can confirm this is still a problem in osp13. Curiously, it only happens when the volume is freshly created. On the second attempt, the volume is not automatically selected, so the normal mechanism hides the extra fields (volume size and the second "delete volume on instance delete".

It seems like the code that is supposed to hide the fields when "volume" is selected is not getting run when the volume is pre-selected.

Comment 5 Radomir Dopieralski 2018-08-28 14:56:57 UTC
The problem is not present in OSP14 or later, because in those versions selecting "launch as instance" doesn't pre-fill the volume field. That is probably a separate (or related) bug.

Comment 7 Radomir Dopieralski 2018-09-18 09:21:16 UTC
This has been now fixed as a part of another bug fix.

Comment 8 Radomir Dopieralski 2018-09-19 12:23:14 UTC
*** Bug 1624719 has been marked as a duplicate of this bug. ***

Comment 13 errata-xmlrpc 2019-09-21 11:15:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:2811