Bug 1542180
Summary: | rsync: fails to start if the current directory is unreachable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Florian Weimer <fweimer> | ||||||
Component: | rsync | Assignee: | Pavel Zhukov <pzhukov> | ||||||
Status: | CLOSED WONTFIX | QA Contact: | BaseOS QE Security Team <qe-baseos-security> | ||||||
Severity: | urgent | Docs Contact: | |||||||
Priority: | high | ||||||||
Version: | 7.5-Alt | CC: | bugzilla, mruprich, rhinduja, szidek, thozza | ||||||
Target Milestone: | rc | ||||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2018-02-22 05:17:17 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 1534635 | ||||||||
Attachments: |
|
Description
Florian Weimer
2018-02-05 18:58:02 UTC
Created attachment 1392075 [details] rsync patch Posted for upstream review: https://lists.samba.org/archive/rsync/2018-February/031476.html Created attachment 1392082 [details]
rsync patch
Got tricked by Git and submitted the wrong patch.
Glusterfs problem also reported here: bug 1542979 I've dig into the issue a bit more. Actually there is bug in rsync which *allowed* it to operate if directory is unavailable (i.e. getcwd() returned (unavailable)/path before the CVE fixed). It's clear from the util.c:change_dir() and [1] that it was designed to prevent this situation as it may lead undefined behavior. IMO Gluster's code should be changed to not exec() applications from unmounted directory instead of putting all rsync users on risk of running from withing unavailable directory. Small reproducer is in [1] and looks like: mkdir test && cd test && rmdir ../test && rsync /etc/fstab /tmp/ [1] https://bugzilla.samba.org/show_bug.cgi?id=6422 Based on #13 I'm closing this bug. @Florian, thank you for your time and patch provided. However it's too risky to operate if current directory is not available and upper level software (in this case it's gluster) should take care of this. |