Bug 1542559

Summary: smilint crashes when parsing a file with some syntax errors
Product: [Fedora] Fedora Reporter: Hedayat Vatankhah <hedayatv>
Component: libsmiAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 27CC: jose.p.oliveira.oss, jsafrane, tcallawa
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-30 22:02:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
MIB 1
none
Second MIB file none

Description Hedayat Vatankhah 2018-02-06 15:02:23 UTC
Created attachment 1392118 [details]
MIB 1

Description of problem:
smilint crashes with segmentation fault

Version-Release number of selected component (if applicable):
libsmi-0.4.8-20.fc27.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Copy the attached files to an empty directory
2. Go to that directory
3. run: smilint ./*

Actual results:
]% smilint ./*
./FOLANI-MIB:4: failed to locate MIB module `SNMPv2-SI'
./FOLANI-MIB:18: unknown object identifier label `enterprises'
zsh: segmentation fault (core dumped)  smilint ./*


Expected results:
No crash!

Comment 1 Hedayat Vatankhah 2018-02-06 15:03:21 UTC
Created attachment 1392119 [details]
Second MIB file

Comment 2 Tom "spot" Callaway 2018-02-06 20:21:13 UTC
On Fedora rawhide, I cannot reproduce this segfault:

[spot@localhost test]$ ls -l
total 8
-rw-rw-r--. 1 spot spot 461 Feb  6 15:20 TEST2.MIB
-rw-rw-r--. 1 spot spot 552 Feb  6 15:19 TEST.MIB
[spot@localhost test]$ smilint ./*
./TEST2.MIB:5: failed to locate MIB module `FOLANI-MIB'
./TEST2.MIB:18: unknown object identifier label `folan'
./TEST.MIB:4: failed to locate MIB module `SNMPv2-SI'
./TEST.MIB:18: unknown object identifier label `enterprises'
[spot@localhost test]$

Comment 3 Hedayat Vatankhah 2018-02-07 15:08:10 UTC
File names DOES matter (see the error: failed to locate MIB module FOLANI-MIB). Sorry, I didn't notice that file names are lost in attachments. Please name the first file as FOLANI-MIB, and the second one as MYLC-MIB (the first word in the MIB file should be equal to the file name. a .txt extension can be added to the file name though).

Comment 4 Ben Cotton 2018-11-27 15:07:07 UTC
This message is a reminder that Fedora 27 is nearing its end of life.
On 2018-Nov-30  Fedora will stop maintaining and issuing updates for
Fedora 27. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora  'version' of '27'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 27 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2018-11-30 22:02:49 UTC
Fedora 27 changed to end-of-life (EOL) status on 2018-11-30. Fedora 27 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.