Bug 1542575

Summary: (docker load) of a legacy-format tar archive crashes the daemon
Product: [Fedora] Fedora Reporter: Miloslav Trmač <mitr>
Component: dockerAssignee: Daniel Walsh <dwalsh>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: adimania, admiller, amurdaca, dwalsh, ichavero, jcajka, lsm5, marianne, nalin, santiago
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-26 14:36:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
loop.tar none

Description Miloslav Trmač 2018-02-06 15:24:16 UTC 
Created attachment 1392159 [details]
loop.tar

Description of problem:
(docker load < loop.tar) with the attached file uses 100% CPU, and eventually fails with
> error during connect: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.26/images/load?quiet=0: EOF

while the daemon has crashed with an infinite recursion repeating
> dockerd-current[2194]: github.com/docker/docker/image/tarexport.(*tarexporter).legacyLoadImage(0xc42160cc00, 0xc444588680, 0x40, 0xc4218d55f0, 0x2b, 0xc4aef02f48, 0x25d6400, 0xc4218d6620, 0x0, 0xc48ef072f0)
> dockerd-current[2194]:         /builddir/build/BUILD/docker-584d391084d425cc99142f11d8fb738f0159ce11/_build/src/github.com/docker/docker/image/tarexport/load.go:291 +0x366 fp=0xc48ef07240 sp=0xc48ef07010


This is caused by the 7a066109ccdda252cab0e3a4946821333b7e88c99a20d45bac10d4462f6788ec/json file having the same value in the "id" and "parent" fields, triggering
>         if img.Parent != "" {
>                 for {
>                         var loaded bool
>                         if parentID, loaded = loadedMap[img.Parent]; !loaded {
>                                 if err := l.legacyLoadImage(img.Parent, sourceDir, loadedMap, progressOutput); err != nil {

Version-Release number of selected component (if applicable):
docker-1.13.1-44.git584d391.fc26.x86_64 , seems the same upstream
Comment 1 Fedora End Of Life 2018-05-03 07:58:42 UTC 
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Comment 2 Miloslav Trmač 2018-05-15 14:26:59 UTC 
Same in docker-1.13.1-51.git4032bd5.fc28.x86_64 .
Comment 3 Ben Cotton 2019-05-02 19:22:46 UTC 
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 4 Miloslav Trmač 2019-05-02 19:47:31 UTC 
Same in docker-1.13.1-65.git1185cfd.fc28.x86_64, looking at %changelog, likely to exist in F30 as well.
Comment 5 Ben Cotton 2020-04-30 22:09:21 UTC 
This message is a reminder that Fedora 30 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '30'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 30 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 6 Ben Cotton 2020-05-26 14:36:04 UTC 
Fedora 30 changed to end-of-life (EOL) status on 2020-05-26. Fedora 30 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.