Bug 1542743

Summary: Unable to build 'dogtag-pki' meta package in Fedora rawhide
Product: [Fedora] Fedora Reporter: Matthew Harmsen <mharmsen>
Component: dogtag-pkiAssignee: Matthew Harmsen <mharmsen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: ajax, alee, edewata, ffesti, fweimer, ignatenko, john.j5live, jonathan, kwright, mharmsen, pmatilai, praiskup
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dogtag-pki-10.5.5-1.fc28 dogtag-pki-10.6.0-0.2.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-18 00:48:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
dogtag-pki.spec (identical for f27 and master)
none
build.log (Fedora 27)
none
build.log (master - Fedora 28 rawhide) none

Description Matthew Harmsen 2018-02-06 22:51:45 UTC 
The Dogtag team produces a kind of meta-package that contains just a directory and a README (no tarball):

* /usr/share/doc/dogtag-pki
* /usr/share/doc/dogtag-pki/README

The purpose of the package is to simply install the entire set of Dogtag packages including all subsystems, pkiconsole, GUI theme packages, etc.

Using Koji, this package has always built, and I have attached the following:
* a copy of the common spec file
* a copy of the build.log for a successful Fedora 27 build, and
* a copy of the build.log for a failing Fedora 28 (rawhide) build

Prior to the Fedora 28 failure, note that the following lines appear in the Fedora 28 log, but not the Fedora 27 log:

. . .
+ /usr/lib/rpm/redhat/brp-ldconfig
/sbin/ldconfig: Warning: ignoring configuration file that cannot be opened: /etc/ld.so.conf: No such file or directory
. . .
+ /usr/lib/rpm/redhat/brp-mangle-shebangs
/usr/lib/rpm/redhat/brp-mangle-shebangs: line 8: cd: /builddir/build/BUILDROOT/dogtag-pki-10.5.5-1.fc28.noarch: No such file or directory

I see two other recent bugs that may be related:
* Bug 1540971 - /sbin/ldconfig: Warning: ignoring configuration file that cannot be opened: /etc/ld.so.conf
* Bug 1541318 - Don't mangle shebangs which are not picked up by RPM generators

Any hints that can be provided to allow this package to build rawhide in Koji would be appreciated.
Comment 1 Matthew Harmsen 2018-02-06 22:55:09 UTC 
Created attachment 1392427 [details]
dogtag-pki.spec (identical for f27 and master)

dogtag-pki.spec common to both Fedora 27 (koji/dogtag-pki/f27/) and Fedora 28 (koji/dogtag-pki/master)
Comment 2 Matthew Harmsen 2018-02-06 22:57:33 UTC 
Created attachment 1392428 [details]
build.log (Fedora 27)

Contents of the successful build.log for Fedora 27.
Comment 3 Matthew Harmsen 2018-02-06 22:59:47 UTC 
Created attachment 1392429 [details]
build.log (master - Fedora 28 rawhide)

Contents of the failed build.log for Fedora 28 (rawhide).
Comment 4 Panu Matilainen 2018-02-07 08:27:54 UTC 
The ldconfig warning can be ignored, the problem is brp-mangle-shebangs expecting a buildroot to always exist, which is a bug that needs fixing in the script. In the meanwhile, this will let you build the package:

%undefine __brp_mangle_shebangs
Comment 5 Panu Matilainen 2018-02-07 14:06:26 UTC 
Something about this left me with a nagging feeling that there's something fishy here. On further thought: the brp-scripts are executed in %__os_install_post, ie at the end of %install section. So if we have an %install section, how come there's no buildroot?

Well, the dogtag-pki package contains this bizarre construct (maybe it's a leftover from some ancient version):

%install
rm -rf %{buildroot}

The fix to this problem is to eliminate the bogus %install section from the spec. No workarounds needed, or fixes to redhat-rpm-config.
Comment 6 Matthew Harmsen 2018-02-07 22:13:34 UTC 
(In reply to Panu Matilainen from comment #5)
> Something about this left me with a nagging feeling that there's something
> fishy here. On further thought: the brp-scripts are executed in
> %__os_install_post, ie at the end of %install section. So if we have an
> %install section, how come there's no buildroot?
> 
> Well, the dogtag-pki package contains this bizarre construct (maybe it's a
> leftover from some ancient version):
> 
> %install
> rm -rf %{buildroot}
> 
> The fix to this problem is to eliminate the bogus %install section from the
> spec. No workarounds needed, or fixes to redhat-rpm-config.

Thanks!  This did the trick!
Comment 7 Fedora End Of Life 2018-02-20 15:33:22 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.
Comment 8 Fedora Update System 2018-03-16 21:08:55 UTC 
freeipa-4.6.90.pre1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2fd7295cb9
Comment 9 Fedora Update System 2018-03-17 19:29:34 UTC 
dogtag-pki-10.6.0-0.2.fc28, dogtag-pki-theme-10.6.0-0.2.fc28, freeipa-4.6.90.pre1-1.fc28, pki-console-10.6.0-0.2.fc28, pki-core-10.6.0-0.2.fc28, tomcat-8.5.29-1.fc28, tomcatjss-7.3.0-0.2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2fd7295cb9
Comment 10 Fedora Update System 2018-03-18 00:48:26 UTC 
dogtag-pki-10.6.0-0.2.fc28, dogtag-pki-theme-10.6.0-0.2.fc28, freeipa-4.6.90.pre1-1.fc28, pki-console-10.6.0-0.2.fc28, pki-core-10.6.0-0.2.fc28, tomcat-8.5.29-1.fc28, tomcatjss-7.3.0-0.2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.