Bug 1542861

Summary: [CNS] Installation failed with glusterfs_heketi_route undefined error when enable openshift_storage_glusterfs_registry_block_storageclass with glusterfs_registry group
Product: OpenShift Container Platform Reporter: Wenkai Shi <weshi>
Component: InstallerAssignee: Jose A. Rivera <jarrpa>
Status: CLOSED ERRATA QA Contact: Wenkai Shi <weshi>
Severity: high Docs Contact:
Priority: high    
Version: 3.9.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---   
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of:
: 1560424 1560430 (view as bug list) Environment:
Last Closed: 2018-03-28 14:26:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Wenkai Shi 2018-02-07 08:10:48 UTC
Description of problem:
Installation failed when enable openshift_storage_glusterfs_registry_block_storageclass with glusterfs_registry group

Version-Release number of the following components:
openshift-ansible-3.9.0-0.39.0.git.0.fea6997.el7
ansible-2.4.3.0-1.el7ae

How reproducible:
100%

Steps to Reproduce:
1. Install CNS with openshift_storage_glusterfs_registry_block_storageclass with glusterfs_registry group
# cat hosts
[OSEv3:children]
masters
nodes
etcd
glusterfs_registry
[OSEv3:vars]
...
openshift_hosted_registry_storage_kind=glusterfs
openshift_storage_glusterfs_registry_block_storageclass=true
openshift_storage_glusterfs_registry_block_storageclass_default=true
openshift_storageclass_default=false
...
[glusterfs_registry]
...
2.
3.

Actual results:
# ansible-playbook -i hosts -v /usr/share/ansible/openshift-ansible/playbooks/deploy_cluster.yml
...
TASK [openshift_storage_glusterfs : Generate Gluster Block StorageClass file] ***
Wednesday 07 February 2018  06:29:27 +0000 (0:00:01.619)       0:32:20.794 **** 
fatal: [ec2-xx-xx-xx-xx.compute-1.amazonaws.com]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'glusterfs_heketi_route' is undefined"}
...

Expected results:
Installation success.

Additional info:
glusterfs_heketi_route should be determine in TASK [openshift_storage_glusterfs : Determine StorageClass heketi URL], according to install log, it was skip:
...
TASK [openshift_storage_glusterfs : Determine StorageClass heketi URL] *********
Wednesday 07 February 2018  06:27:05 +0000 (0:00:00.026)       0:29:58.288 **** 
skipping: [ec2-xx-xx-xx-xx.compute-1.amazonaws.com] => {"changed": false, "skip_reason": "Conditional result was False"}
...

Conditional of this TASK is [1] and [2], looks like default value of [2] is root cause.

[1]. https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_storage_glusterfs/tasks/glusterfs_common.yml#L298
[2]. https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_storage_glusterfs/tasks/glusterfs_common.yml#L313

Comment 1 Jose A. Rivera 2018-02-08 15:09:08 UTC
PR is upstream: https://github.com/openshift/openshift-ansible/pull/7072

Comment 2 Wenkai Shi 2018-02-12 10:19:59 UTC
PR merged, check with version openshift-ansible-3.9.0-0.42.0.git.0.1a9a61b.el7, installer could pass TASK [openshift_storage_glusterfs : Generate Gluster Block StorageClass file].
Will verify it once move to ON_QA.

Comment 4 Wenkai Shi 2018-02-22 03:44:00 UTC
Verify this per Comment 2.

Comment 7 errata-xmlrpc 2018-03-28 14:26:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489