Bug 1542909

Summary: BSOD on Windows 7 when letting Windows automatically choose the driver from virtio-win iso
Product: Red Hat Enterprise Linux 8 Reporter: Sameeh Jubran <sjubran>
Component: spice-qxl-wddm-dodAssignee: ybendito
Status: CLOSED CURRENTRELEASE QA Contact: SPICE QE bug list <spice-qe-bugs>
Severity: low Docs Contact:
Priority: unspecified    
Version: ---CC: cfergeau, dblechte, lijin, rduda, tpelka, xen-maint, ybendito, yvugenfi
Target Milestone: rcKeywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Windows   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-04 05:13:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Spice RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1713700    

Description Sameeh Jubran 2018-02-07 10:38:50 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Sameeh Jubran 2018-02-07 10:45:19 UTC
When Windows searches for the drivers of qxl for Windows 7 it selects the wddm drivers which are aimed for win 8+. This should be prevented somehow as it causes
BSOD in win 7.

This was reported on Virtio-win guest drivers repository on github: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/244

Comment 2 Daniel Berrangé 2018-02-07 13:32:35 UTC
There's nothing libvirt can do about this - it just exposes whatever hardware it was asked to. If the mgmt app or admin provided a Windows driver disk with the wrong versions, its not libvirt's fault.

Comment 3 Sameeh Jubran 2018-02-07 13:43:57 UTC
This should be resolved at the driver level, I think that it can be done in the inf file.

Comment 4 Sameeh Jubran 2018-02-07 13:44:04 UTC
This should be resolved at the driver level, I think that it can be done in the inf file.

Comment 6 lijin 2018-03-19 05:49:21 UTC
The component should be spice if fix is in qxl drivers.

Correct me if I'm wrong.

Comment 7 Christophe Fergeau 2018-03-19 11:10:31 UTC
(In reply to Sameeh Jubran from comment #4)
> This should be resolved at the driver level, I think that it can be done in
> the inf file.

The inf file for the win7 QXL driver is https://cgit.freedesktop.org/spice/win32/qxl/tree/xddm/miniport/qxl.inf , any idea of the adjustments that need to be made there? Or is this the qxl-wddm-dod inf file which needs to be changed to say it only supports win8+?

Comment 8 Yvugenfi@redhat.com 2018-03-20 09:41:53 UTC
(In reply to Christophe Fergeau from comment #7)
> (In reply to Sameeh Jubran from comment #4)
> > This should be resolved at the driver level, I think that it can be done in
> > the inf file.
> 
> The inf file for the win7 QXL driver is
> https://cgit.freedesktop.org/spice/win32/qxl/tree/xddm/miniport/qxl.inf ,
> any idea of the adjustments that need to be made there? Or is this the
> qxl-wddm-dod inf file which needs to be changed to say it only supports
> win8+?

It looks like that qxl-wddm-dod should be changed to support Win8+ only.

Comment 9 Sameeh Jubran 2018-04-16 13:19:49 UTC
A patch that solves the issue was sent to upstream:

https://lists.freedesktop.org/archives/spice-devel/2018-April/043033.html

We decided to limit the installation on upstream to Win 8+ even though the qxl-wddm driver is supported for win10+ in downstream as we don't want to force this  policy on upstream.

Comment 10 Sameeh Jubran 2018-04-23 14:06:56 UTC
The commit that fixes the issue is now in upstream:
https://gitlab.com/spice/qxl-wddm-dod/commit/9b0bc8188366c3eebe1519fa1e153e51ebcdf16b

Comment 11 Sameeh Jubran 2018-04-23 14:17:20 UTC
Changing back to post

Comment 12 Sandro Bonazzola 2019-01-28 09:44:26 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 14 Sandro Bonazzola 2019-03-12 12:54:23 UTC
4.3.1 has been released, please re-target this bug as soon as possible.

Comment 16 ybendito 2019-04-18 11:41:14 UTC
spice-qxl-wddm-dod-0.19-0
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=881523