Bug 1543118

Summary: %build chaos
Product: [Fedora] Fedora Reporter: Tim Landscheidt <tim>
Component: ledgerAssignee: Jim Radford <radford>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: bex, radford
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-28 19:42:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch against f26 to fix various issues. none

Description Tim Landscheidt 2018-02-07 18:28:52 UTC
Currently, ledger.spec's %build looks like:

| %build
| # /usr/include/c++/6.1.1/cstdlib:75:25: fatal error: stdlib.h: No such file.
| # Seems to be related to GCC 6.1, potentially fixed with Boost 1.61.
| # Hack around this for now.
| ./acprep --prefix=%{_prefix} update || :
| sed -i -e 's# -isystem /usr/include##g' src/CMakeFiles/libledger.dir/build.make
| ./acprep --prefix=%{_prefix} update

| %cmake . \
|     -DCMAKE_INSTALL_PREFIX=%{_prefix} \
|     -DCMAKE_SKIP_RPATH:BOOL=ON \
|     -DUSE_PYTHON:BOOL=ON \
|     -DUSE_DOXYGEN:BOOL=ON \
|     -DBUILD_WEB_DOCS:BOOL=ON \
|     -DBUILD_EMACSLISP:BOOL=ON

| sed -i -e 's# -isystem /usr/include##g' src/CMakeFiles/libledger.dir/build.make
| mkdir system.hh.gch
| #make %%{?_smp_mflags}
| make
| make doc

| # Build info files.
| pushd doc
| makeinfo ledger3.texi
| makeinfo ledger-mode.texi
| popd

The error is not directly related to GCC 6.1, but to calling ./acprep: This (by default) sets up a "debug" build which itself then uses "-isystem /usr/include" which causes havoc.

In addition, AFAIUI this will ignore Fedora's defaults for make, cmake & Co. because ./acprep sets them itself and the subsequent cmake and make invocations will not recompile those files.

If one uses cmake and make directly instead, this seems to work (due to how long it takes to compile ledger I have not tested this end to end yet):

| %build
| %cmake . \
|     -DUSE_PYTHON:BOOL=ON \
|     -DUSE_DOXYGEN:BOOL=ON \
|     -DBUILD_WEB_DOCS:BOOL=ON \
|     -DBUILD_EMACSLISP:BOOL=ON

| %make_build

Comment 1 Tim Landscheidt 2018-02-12 14:25:03 UTC
I have addressed the issues in the attached patch for the f26 branch and a scratch build (https://koji.fedoraproject.org/koji/taskinfo?taskID=24953599) succeeds for all but i686 and armv7hl, and I have tested that the resulting RPM works on x86_64.

I will debug the i686 and armv7hl issues next, but wanted to post an intermediate result in case I get bored :-).

Jamie, in 0ca6145a9cb1366ab3fa8f471e4c2d68661a8877 you added:

| # Avoid texinfo errors on EL7.
| %if 0%{?rhel} == 7
| sed -i -e 's#FIXME:UNDOCUMENTED#FIXMEUNDOCUMENTED#g' doc/ledger3.texi
| %endif

to %prep.  What are those errors and is there a (public) bug for them?

Comment 2 Tim Landscheidt 2018-02-12 14:26:06 UTC
Created attachment 1394935 [details]
Patch against f26 to fix various issues.

Comment 3 Fedora End Of Life 2018-02-20 15:33:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 4 Tim Landscheidt 2018-02-20 15:38:00 UTC
The failures on 32-bit architectures are just an indicator of a memory access error present in 64-bit builds as well; cf. https://github.com/ledger/ledger/issues/541.

Comment 5 Ben Cotton 2019-05-02 22:01:37 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Ben Cotton 2019-05-28 19:42:12 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.