Bug 1543440
| Summary: | CreateImageTemplateCommand failure needs to be be indicated with clearer message in GUI | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Kevin Alon Goldblatt <kgoldbla> | ||||||
| Component: | BLL.Storage | Assignee: | shani <sleviim> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Evelina Shames <eshames> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 4.2.1 | CC: | bugs, ebenahar, tnisan | ||||||
| Target Milestone: | ovirt-4.3.0 | Flags: | ylavi:
ovirt-4.3+
|
||||||
| Target Release: | 4.3.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | ovirt-engine-4.3.0_alpha | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2019-02-13 07:48:10 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1393191 [details]
engine and vdsm logs
adding logs
This message should never happen, instead we should add a proper validation Created attachment 1459931 [details]
Works on master-7b828a9092d
I've tried to reproduce on ovirt-engine-master-7b828a9092d
The template was successfully created with a disk's alias of 125 chars.
(engine.log and a screenshot are attached).
This one happens for aliases > 255 chars. I'll work on a fix. Verified. Version: Engine - 4.3.0-0.0 This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. Closed by mistake, moving back to qa -> verified This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Description of problem: Creating a template and entering a long string in the disk alias causes the create template operation to fail. The message is not clear and can only be found in the engine log Engine log: ---------------------------- 2018-02-08 12:52:38,549+02 INFO [org.ovirt.engine.core.bll.tasks.AsyncTaskManager] (default task-12) [0a1ecba9-3c09-49fd-aac5-0251d6d7958b] Adding task '6bfcadeb-0360-4c62-be7f-28541ae61a0c' (Parent Command 'Cr eateAllTemplateDisks', Parameters Type 'org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters'), polling hasn't started yet.. 2018-02-08 12:52:38,559+02 ERROR [org.ovirt.engine.core.bll.storage.disk.image.CreateImageTemplateCommand] (default task-12) [0a1ecba9-3c09-49fd-aac5-0251d6d7958b] Command 'org.ovirt.engine.core.bll.storage.disk .image.CreateImageTemplateCommand' failed: CallableStatementCallback; SQL [{call insertbasedisk(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)}]; ERROR: value too long for type character varying(255) Where: SQL statement "INSERT INTO base_disks ( disk_id, wipe_after_delete, propagate_errors, disk_alias, disk_description, shareable, sgio, alignment, last_alignment_scan, disk_storage_type, cinder_volume_type, disk_content_type ) VALUES ( v_disk_id, v_wipe_after_delete, v_propagate_errors, v_disk_alias, v_disk_description, v_shareable, v_sgio, v_alignment, v_last_alignment_scan, v_disk_storage_type, v_cinder_volume_type, v_disk_content_type )" Version-Release number of selected component (if applicable): ovirt-engine-4.2.1.3-0.1.el7.noarch vdsm-4.20.17-32.git9b853be.el7.centos.x86_64 How reproducible: 100% Steps to Reproduce: 1. Create VM with disk 2. Right click Vm in VM tab and select create template 3. Change the disk alias to a long character string of a 100 characters and press OK >>>>>> message displayed "Error while executing action New VM Template: Internal Engine Error" 4. Hover over alias field >>>>> a)Alias field is not highlighted in Red and b)No information is given of field limitations Actual results: After failed template creation due to too long string in Alias field, Hover over alias field >>>>> 1. Alias field is not highlighted in Red and 2.No information is given of field limitations Expected results: 1. Correct message should be displayed 2. Alias field should be highlighted in Red 3. Correct information should be displayed indicating field limitations like "Maximum field length is ......2 " Additional info: