Bug 1543819

Summary:	libvpx: Incomplete Fedora build flags injection
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	libvpx	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	tcallawa, wtaymans
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-12 21:17:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Description Florian Weimer 2018-02-09 11:34:53 UTC

libvpx-1.7.0-1.fc28 does not use the complete Fedora build flags for everything.  At least LDFLAGS injection is imperfect:

gcc -I/builddir/build/BUILD/libvpx-1.7.0/third_party/libwebm -I/builddir/build/BUILD/libvpx-1.7.0/vp8 -I/builddir/build/BUILD/libvpx-1.7.0/vp8 -I/builddir/build/BUILD/libvpx-1.7.0/vp9 -I/builddir/build/BUILD/libvpx-1.7.0/vp9 -I/builddir/build/BUILD/libvpx-1.7.0/third_party/libyuv/include -m64 -DNDEBUG -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Wdeclaration-after-statement -Wdisabled-optimization -Wfloat-conversion -Wpointer-arith -Wtype-limits -Wcast-qual -Wvla -Wimplicit-function-declaration -Wuninitialized -Wunused -Wextra -Wundef -I. -I"/builddir/build/BUILD/libvpx-1.7.0" -M examples/simple_decoder.c | sed -e 's;^\([a-zA-Z0-9_]*\)\.o;examples/simple_decoder.c.o examples/simple_decoder.c.d;' > examples/simple_decoder.c.d

That leads to missing BIND_NOW/RELRO for various binaries.


More information about RPM macros to set CFLAGS and LDFLAGS is available here:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md

Comment 1 Tom "spot" Callaway 2018-02-12 21:17:00 UTC

I believe the correct flags are now used in libvpx-1.7.0-5.fc28. Please reopen if this is not the case.