Bug 1543845

Summary: nss: Build flags injection only partially successful
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: nssAssignee: Daiki Ueno <dueno>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: dueno, elio.maldonado.batiz, kdudka, kengert
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nss-3.37.3-1.1.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-21 13:03:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1539083    

Description Florian Weimer 2018-02-09 12:22:01 UTC
/usr/bin/certutil and other programs in nss-tools-3.35.0-4.fc28.x86_64 are not linked with the standard LDFLAGS from redhat-rpm-config.

More information about RPM macros to set CFLAGS and LDFLAGS is available here:
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md

Comment 1 Fedora End Of Life 2018-02-20 15:24:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Daiki Ueno 2018-03-12 16:00:28 UTC
I simply added "LDFLAGS=$RPM_LD_FLAGS; export LDFLAGS" in the spec:
https://src.fedoraproject.org/rpms/nss/c/03874d12724f28a6df4d78e48d8315a6d8e423dc?branch=master
and the build seems to pick up the correct flags:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25659474

This might be suboptimal; maybe we could:
- respect $LDFLAGS already set in the shell environment
- introduce a separate make variable, e.g., XLDFLAGS analogous to XCFLAGS

Comment 3 Daiki Ueno 2018-06-21 13:03:25 UTC
This should be fixed in the current update of the nss package.  Feel free to reopen if it is not the case.