Bug 1544012

Summary:	pull request: spec cleanups
Product:	[Fedora] Fedora	Reporter:	Tomasz Kłoczko <kloczko.tomasz>
Component:	openal-soft	Assignee:	Andreas Bierfert <andreas.bierfert>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	andreas.bierfert, hdegoede
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openal-soft-1.18.2-5.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-06 17:26:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomasz Kłoczko 2018-02-09 20:44:50 UTC

https://src.fedoraproject.org/rpms/openal-soft/pull-request/2

Copy of the %changelog entry:

* Fri Feb 09 2018 Tomasz Kłoczko <kloczek> - 1.18.2-4
- remove support for no longer suppoerted Fedora versions (<=25)
- fix: add %%{_libdir}/cmake/OpenAL directory to devel
- fix: s/_datarootdir/_datadir/ as this package does not uses datarootdir
  but datadir
- fix: add %%{_datatdir}/openal to main package as well and to %%exclude
  %%{_datatdir}/openal/{alsoftrc.sample,presets/presets.txt} as those files
  are not needed
- removed Group fields
  (https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections)
- add use more macros (%%autosetup, %%make_build, %%make_install)

Additional changes:
    - sort alphabetically BuildRequires entries
    - remove no longer used patches

Comment 1 Fedora End Of Life 2018-02-20 15:25:53 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Tomasz Kłoczko 2018-02-22 15:46:46 UTC

May I ask package maintainer to respond?

Comment 3 Hans de Goede 2018-02-22 18:55:31 UTC

This is on my todo list, but it hardly is a high priority thing and it has been less then 2 weeks ago since you opened this bug...

Comment 4 Hans de Goede 2018-02-26 10:05:12 UTC

https://src.fedoraproject.org/rpms/openal-soft/c/24e87f27f4bbba4ffc71af3e4995e99d21534933

And further commits do not even build because of a datatdir typo (instead of datadir). It would be nice if next time you at least do a test-build before submitting a pull-req. I need to do some other changes too anyways, so I will fix this up.

Also this does not hash well with your hurry to get this merged, next time please make sure you test your changes before pinging others to get things merged.

Comment 5 Fedora Update System 2018-02-26 11:53:15 UTC

openal-soft-1.18.2-5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-91006aeaa5

Comment 6 Tomasz Kłoczko 2018-02-26 16:21:30 UTC

Typo was probably because I've forgotten to copy correct spec file to git directory.

Sorry and thank you.

Comment 7 Fedora Update System 2018-02-26 17:33:06 UTC

openal-soft-1.18.2-5.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-91006aeaa5

Comment 8 Fedora Update System 2018-03-06 17:26:33 UTC

openal-soft-1.18.2-5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.