Bug 1544256

Summary: Some advanced customization steps are no longer valid in RHOSP12
Product: Red Hat OpenStack Reporter: David Hill <dhill>
Component: openstack-tripleo-heat-templatesAssignee: David Peacock <dpeacock>
Status: CLOSED CURRENTRELEASE QA Contact: Gurenko Alex <agurenko>
Severity: medium Docs Contact:
Priority: medium    
Version: 12.0 (Pike)CC: aschultz, dhill, dpeacock, emacchi, martinsson.patrik, mburns, rhel-osp-director-maint, sbaker, slinaber
Target Milestone: Upstream M1Keywords: Triaged, ZStream
Target Release: 15.0 (Stein)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1635334 1635336 (view as bug list) Environment:
Last Closed: 2019-01-28 14:04:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1635334, 1635336    

Description David Hill 2018-02-11 18:07:13 UTC
Description of problem:
Some advanced customization steps are no longer valid in RHOSP12 using hieradata because of the way puppet manifests are applied to containers by setting FACTER_uuid=docker instead of the instance UUID as before.

Namely through '/var/lib/docker-puppet/docker-puppet.sh', which is executing puppet like this, 

$ > FACTER_hostname=$HOSTNAME FACTER_uuid=docker /usr/bin/puppet apply         --detailed-exitcodes --color=false --logdest syslog --logdest console $TAGS /etc/config.pp

This will obviously make all hiera-customization to containerized-services based on the servers UUID to fail. According to this article, https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/12/html-single/advanced_overcloud_customization/index#sect-Customizing_Hieradata_for_Individual_Nodes there is no mention of this, and this is how its supposed to be done.



resource_registry:
  OS::TripleO::ComputeExtraConfigPre: /usr/share/openstack-tripleo-heat-templates/puppet/extraconfig/pre_deploy/per_node.yaml
parameter_defaults:
  NodeDataLookup: '{"F5055C6C-477F-47FB-AFE5-95C6928C407F": {"nova::compute::vcpu_pin_set": [ "2", "3" ]}}'

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Irina Petrova 2018-03-16 13:22:12 UTC
Any progress, guys?

Comment 3 Steve Baker 2018-04-05 23:15:32 UTC
I've proposed this fix upstream.

Comment 8 Irina Petrova 2018-11-14 16:15:30 UTC
@Alex: I see you switched the version to RHOSP-15 but are we backporting this patch to RHOSP-12? 

Should I create another BZ?

Comment 9 Alex Schultz 2018-11-14 16:43:01 UTC
We will likely not be able to backport this to OSP12 prior to the end of the Maintenance support for OSP12 (https://access.redhat.com/support/policy/updates/openstack/platform/). We have proactively backported this to upstream Queens so it will be available in 13 in a later zstream.