Bug 1544326

Summary: [OVN] - "Default" cluster always returns to default network provider on engine-setup although was set with No default provider
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: BLL.NetworkAssignee: Dominik Holler <dholler>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: medium Docs Contact:
Priority: low    
Version: 4.2.1.4CC: bugs, danken, dholler, ylavi
Target Milestone: ovirt-4.2.2Keywords: Reopened
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: ovirt-4.3+
ylavi: exception+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-29 11:09:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Logs none

Description Michael Burman 2018-02-12 07:33:26 UTC
Created attachment 1394797 [details]
Logs

Description of problem:
[OVN] - Default cluster always returns to default network provider on engine-setup although was set with No default provider.

The default behaviour for the default cluster is to always set ovirt-provider-ovn on engine-setup, although the user/admin has decided that the default cluster will be set with No Default Provider. 

Version-Release number of selected component (if applicable):
4.2.1.6-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Run latest RHV 4.2
2. Set the default cluster with Default Network Provider=No Default Provider
3. Run engine-setup

Actual results:
Default cluster return to be set with Default Network Provider=ovirt-provider-ovn

Expected results:
If the admin/user has decided to set the default cluster as No Default Cluster, then on engine-setup we shouldn't return the default network provider for the default cluster.

Comment 1 Dan Kenigsberg 2018-02-14 12:26:22 UTC
After discussing this with Dominik, I recall that this is a known problem in our implementation. The step where ovirt-engine-setup creates the provider and adds it to the Default cluster is independent of the step where the Default cluster is created. It can certainly not know if the Default cluster was already long ago, and the provider was explicitly removed from it. For that, Engine would have to leave a filesystem hint when removing the provider from the cluster.

I don't see a simple way to solve this; a simple workaround for the user is to rename the cluster to something other than "Default".

Comment 2 Michael Burman 2018-02-19 07:10:28 UTC
qe are not OK with closing this report. Will discuss it on the weekly scrub.

Comment 3 Michael Burman 2018-02-19 09:59:21 UTC
Hi Dominik,

During engine-setup, do we aware if it's a clean installation or upgrade?
If we do, then we can touch the default only on clean install and on upgrade to not touch the ovn configuration for the default cluster and this way to handle this issue. 
Renaming the default cluster name is an ugly WA.

Comment 4 Dominik Holler 2018-02-21 10:14:35 UTC
Sounds like a good alternative. I will check this.

Comment 5 Dominik Holler 2018-02-22 13:32:13 UTC
We can touch the clusters with name 'Default' if the ovirt-provider-ovn is configured. This will occur only if the provider is installed the first time, but not on upgrading an existing installation.

Comment 6 Michael Burman 2018-03-06 08:36:20 UTC
Verified on - 4.2.2.2-0.1.el7

Comment 7 Sandro Bonazzola 2018-03-29 11:09:07 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.