Bug 1544476

Summary: Ping was deprecated in favor of ping2 and confirmConnectivity
Product: [oVirt] mom Reporter: Mor <mkalfon>
Component: GeneralAssignee: Andrej Krejcir <akrejcir>
Status: CLOSED CURRENTRELEASE QA Contact: Mor <mkalfon>
Severity: medium Docs Contact:
Priority: medium    
Version: 0.5.11CC: akrejcir, bugs, danken, fromani, lveyde, sbonazzo, ylavi
Target Milestone: ovirt-4.2.2Flags: rule-engine: ovirt-4.2+
ylavi: exception+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mom-0.5.12 Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-29 11:11:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
vdsm and mom logs none

Description Mor 2018-02-12 15:52:55 UTC
Created attachment 1394978 [details]
vdsm and mom logs

Description of problem:
Warning appear in vdsm.log:
When restarting vdsmd on host, warning is logged in vdsm.log: 'ping was deprecated in favor of ping2 and confirmConnectivity'.

Version-Release number of selected component (if applicable):
RHV 4.2.1.6-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Restart vdsmd on host.

Actual results:
Warning in vdsm.log.
2018-02-12 17:49:26,406+0200 WARN  (jsonrpc/1) [root] ping was deprecated in favor of ping2 and confirmConnectivity (API:1295)

Expected results:
No warning.

Additional info:

Comment 1 Dan Kenigsberg 2018-02-15 11:16:21 UTC
changing assignee and team since Andrej already has fixed the bug in master.

Comment 2 Sandro Bonazzola 2018-02-15 12:15:22 UTC
Looks like this bug missed 4.2.2 RC1 since mom has not been built and released.
Can you please issue a build for next week compose?

Comment 3 Mor 2018-02-22 11:43:39 UTC
I still see the error in vdsm.log:

2018-02-22 13:36:01,091+0200 INFO  (Reactor thread) [ProtocolDetector.AcceptorImpl] Accepted connection from ::1:37604 (protocoldetector:61)
2018-02-22 13:36:01,099+0200 INFO  (Reactor thread) [ProtocolDetector.Detector] Detected protocol stomp from ::1:37604 (protocoldetector:125)
2018-02-22 13:36:01,099+0200 INFO  (Reactor thread) [Broker.StompAdapter] Processing CONNECT request (stompreactor:103)
2018-02-22 13:36:01,100+0200 INFO  (JsonRpc (StompReactor)) [Broker.StompAdapter] Subscribe command received (stompreactor:132)
2018-02-22 13:36:01,141+0200 WARN  (jsonrpc/0) [root] ping was deprecated in favor of ping2 and confirmConnectivity (API:1295)


Are we sure that the fix is in?

RHV 4.2.2-2

Installed packages:
mom-0.5.12-1.el7ev.noarch
vdsm-4.20.19-1.el7ev.x86_64

Comment 4 Mor 2018-02-25 09:48:21 UTC
I searched the source code for references to this warning message, I noticed that in vdsm/lib/vdsm/momIF.py/momIF.py in getStatus method we call ping().

Comment 5 Red Hat Bugzilla Rules Engine 2018-02-25 09:48:26 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Francesco Romani 2018-03-14 12:48:52 UTC
Sorry for the noise, we can have this in 4.2.2, the mom package 0.5.12 is available.

To improve the visibility of those issues and to speed up the merge process, next time please make sure to add the relevant infos as gerrit comments.

Comment 7 Francesco Romani 2018-03-14 13:19:29 UTC
please note that this patch is included only in Vdsm 4.20.22, not before - especially not in 4.20.21

Comment 8 Mor 2018-03-18 07:14:42 UTC
Verified on:
vdsm-4.20.22-1.el7ev.x86_64

Comment 9 Sandro Bonazzola 2018-03-29 11:11:11 UTC
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.