Bug 1544510
| Summary: | AvogadroLibsConfig.cmake: set(AvogadroLibs_INCLUDE_DIRS "${AvogadroLibs_INSTALL_PREFIX}//usr/include/avogadro2") | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | avogadro2-libs | Assignee: | Antonio T. (sagitter) <anto.trande> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 28 | CC: | anto.trande |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | avogadro2-libs-1.90.0-15.fc26 avogadro2-libs-1.90.0-15.fc27 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-02-24 21:39:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1544514 | ||
Fixed with release avogadro2-libs-1.90.0-14.fc28 Please, try it. FYI, you shouldn't need to explicitly set,
-DCMAKE_INSTALL_PREFIX:PATH=%{_prefix}
the %cmake macro should do that for you already
Thanks, confirmed good (I think... now seeing failures elsewhere, but not avogadro related). I take that back, it was avogadro related, another separate issue:
from AvogadroLibsTargets-release.cmake :
# Import target "AvogadroRendering" for configuration "Release"
set_property(TARGET AvogadroRendering APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(AvogadroRendering PROPERTIES
IMPORTED_LINK_INTERFACE_LIBRARIES_RELEASE "/usr/lib64/libGLEW.so;/usr/lib64/libGL.so;/usr/lib64/libGLU.so"
IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib64/libAvogadroRendering.so"
IMPORTED_SONAME_RELEASE "libAvogadroRendering.so"
)
means it always tries to link GLEW GL GLU, except avogadro2-libs-devel has no dependency on GLEW, so linking fails:
make[2]: *** No rule to make target '/usr/lib64/libGLEW.so', needed by 'compoundviewer/libcompoundviewer.so.5.0.0'. Stop.
Probably simpliest short-term fix, is to explicitly add some dependencies to avogadro2-libs-devel:
Requires: glew-devel%{?_isa}
Requires: libGL-devel%{?_isa}
Requires: libGLU-devel%{?_isa}
Long term, I think linkage of those extra libraries could probably be removed (may only be needed when linking statically).
Another one,
# Import target "AvogadroCore" for configuration "Release"
set_property(TARGET AvogadroCore APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(AvogadroCore PROPERTIES
IMPORTED_LINK_INTERFACE_LIBRARIES_RELEASE "/usr/lib64/libsymspg.so"
IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib64/libAvogadroCore.so"
IMPORTED_SONAME_RELEASE "libAvogadroCore.so"
)
with an implicit dependency on /usr/lib64/libsymspg.so (provided by spglib-devel)
Added new explicit dependencies: https://koji.fedoraproject.org/koji/taskinfo?taskID=25037448 Looks good, thanks! Mind issuing updates for f27 (and possibly f26)? avogadro2-libs-1.90.0-15.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-bacb01da2c avogadro2-libs-1.90.0-15.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ba7203114 avogadro2-libs-1.90.0-15.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ba7203114 avogadro2-libs-1.90.0-15.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-bacb01da2c This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle. Changing version to '28'. avogadro2-libs-1.90.0-15.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. avogadro2-libs-1.90.0-15.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |
Looks like AvogadroLibsConfig.cmake expects a relative path, but an absolute one is passed in %build: -DCMAKE_INSTALL_INCLUDEDIR:PATH=%{_includedir}/avogadro2