Bug 154462

Summary: sensors-detect gives bad advice;here's a little patch
Product: [Fedora] Fedora Reporter: David Tonhofer <bughunt>
Component: lm_sensorsAssignee: Phil Knirsch <pknirsch>
Status: CLOSED DEFERRED QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 3CC: rvokal
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-05-12 12:24:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch for sensors-detect none

Description David Tonhofer 2005-04-11 22:31:13 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050323 Firefox/1.0.2 Fedora/1.0.2-1.3.1

Description of problem:
Running sensors-detect manually gives confusing/bad advice. I might be
advantageous to modify the script slightly regarding file names and explanations
given. As I don't know what the setup on distros other than Red Hat is, this
is a stab in the dark, but here goes.

Modifications:

The script does not check for '/etc/modprobe.conf' which seems to be standard
under 2.6 but uses only 'old style' names - added.

The advice given to the user to modify the boot init script is unnecessary -
the /etc/sysconfig/lm_sensors file contains the list of modules already. 
Fixed but only if the script finds it's on a Red Hat system. Also:
sensors -s may have to be added manually. Tell the user.

Note that the Red Hat system is detected by checking for /etc/redhat-release.

Additional explanations regarding /etc/sysconfig/lm_sensors given. Also
a warning saying that some modules might not yet have been ported to 2.6!

Use variables for location of boot script and lm_sensors file. The script
seems to assume that the boot script is always /etc/rc.d/init.d/lm_sensors.
Which might be incorrect, but that's what it did originally. 

Putting a GNU copyleft header into /etc/sysconfig/lm_sensors strikes me
as serious overkill. Removed. Yes, I'm arrogant.

Advice to user to copy boot script suppressed on Red Hat systems.









Version-Release number of selected component (if applicable):
lm_sensors-2.8.7-2

How reproducible:
Always

Steps to Reproduce:
n/a 

Actual Results:  n/a

Expected Results:  n/a

Additional info:

n/a
Comment 1 David Tonhofer 2005-04-11 22:35:46 UTC 
Created attachment 112999 [details]
Patch for sensors-detect
Comment 2 Phil Knirsch 2005-09-01 17:39:42 UTC 
I like some parts of the patch, but with 2.9.1 which we now have in FC4 and
later most of the kernel-2.6 issues should be handled properly.

I might put in a trimmed down version of this patch in a later version.

Read ya, Phil