Bug 1544944

Summary: [glocktop] Remove the -f option in the usage message since there is no -f option
Product: Red Hat Enterprise Linux 7 Reporter: Shane Bradley <sbradley>
Component: gfs2-utilsAssignee: Andrew Price <anprice>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.7CC: cluster-maint, gfs2-maint, jpayne, rhandlin
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gfs2-utils-3.1.10-8.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 11:37:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Shane Bradley 2018-02-13 19:58:41 UTC
Description of problem:
The glocktop usage description shows a -f option but there is no -f option.

# /usr/sbin/glocktop -h
Usage:
glocktop [-i] [-d <delay sec>] [-f] [-n <iter>] [-sX] [-c] [-D] [-H] [-r] [-t]


We should remove -f from the usage message. 

Version-Release number of selected component (if applicable):
gfs2-utils-3.1.10-3.el7.x86_64

How reproducible:
Every time.

Steps to Reproduce:
1. /usr/sbin/glocktop -h


Actual results:
The usage message shows a -f option.

Expected results:
The usage message should NOT show a -f option.

Additional info:

Comment 1 Andrew Price 2018-06-22 14:51:26 UTC
Patch has been upstream for some time -> POST

Comment 4 Justin Payne 2018-07-09 17:30:28 UTC
Verified in gfs2-utils-3.1.10-8.el7:

[root@host-110 ~]# rpm -q gfs2-utils
gfs2-utils-3.1.10-8.el7.x86_64
[root@host-110 ~]# glocktop -h
Usage:
glocktop [-i] [-d <delay sec>] [-n <iter>] [-sX] [-c] [-D] [-H] [-r] [-t]

-i : Runs glocktop in interactive mode.
-d : delay between refreshes, in seconds (default: 30).
-n : stop after <iter> refreshes.
-H : don't show Held glocks, even if not waited on, excluding iopen
-r : show reservations when rgrp glocks are displayed
-s : show glock summary information every X iterations
-t : trace directory glocks back
-D : don't show DLM lock status

Comment 6 errata-xmlrpc 2018-10-30 11:37:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3272