Bug 1545153

Summary: No Storage Domain error while restoring a snapshot
Product: [oVirt] ovirt-engine Reporter: Leon Goldberg <lgoldber>
Component: BLL.StorageAssignee: Fred Rolland <frolland>
Status: CLOSED CURRENTRELEASE QA Contact: Evelina Shames <eshames>
Severity: medium Docs Contact:
Priority: unspecified    
Version: futureCC: bugs, ebenahar, eshenitz, frolland, lgoldber, ratamir
Target Milestone: ovirt-4.3.0Keywords: Regression
Target Release: 4.3.0Flags: rule-engine: ovirt-4.3+
rule-engine: blocker+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_alpha Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-13 07:48:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log none

Description Leon Goldberg 2018-02-14 11:46:44 UTC
test_restore_snapshot_with_an_used_mac_implicitly_assigns_new_mac of OST's networking suite now consistently fails during snapshot restoration with
"Cannot preview Snapshot. Storage Domain doesn't exist."

Here is an example job: http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x86_64/4009/

Comment 1 Allon Mureinik 2018-02-14 12:14:50 UTC
(In reply to Leon Goldberg from comment #0)
> test_restore_snapshot_with_an_used_mac_implicitly_assigns_new_mac of OST's
> networking suite now consistently fails during snapshot restoration with
> "Cannot preview Snapshot. Storage Domain doesn't exist."
> 
> Here is an example job:
> http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-
> x86_64/4009/

And now in English?
What's the flow?

Comment 2 Leon Goldberg 2018-02-14 12:29:29 UTC
1) Create a VM (vm0)
2) Create a vNic for vm0 (vnic0) with a given MAC address (mac_addr_0)
3) Run vm0
4) Take a snapshot of vm0 (snapshot0)
5) Modify vnic0's MAC address to mac_addr_1
6) Create another VM (vm1)
7) Create a vNic for vm1 (vnic1) with mac_addr_0
8) Stop vm0
9) Restore the snapshot --> fails with "Cannot preview Snapshot. Storage Domain doesn't exist."

Comment 3 Allon Mureinik 2018-02-14 13:12:52 UTC
Versions?
Logs?

Comment 6 Allon Mureinik 2018-02-14 13:19:45 UTC
(In reply to Leon Goldberg from comment #4)
> Master.
Commit hash? Do you expect me to guess?

Comment 7 Allon Mureinik 2018-02-14 13:23:10 UTC
Created attachment 1395903 [details]
engine.log

Attaching log referenced in comment 4. No sense it relying on another external system...

Comment 8 Leon Goldberg 2018-02-14 13:36:19 UTC
(In reply to Allon Mureinik from comment #6)
> (In reply to Leon Goldberg from comment #4)
> > Master.
> Commit hash? Do you expect me to guess?

Precisely!

Which commit would you like to see? There is no single patch I can refer to. Here's Engine's hash in the logs git28f336b

Comment 9 Leon Goldberg 2018-02-14 13:36:30 UTC
(In reply to Allon Mureinik from comment #6)
> (In reply to Leon Goldberg from comment #4)
> > Master.
> Commit hash? Do you expect me to guess?

Precisely!

Which commit would you like to see? There is no single patch I can refer to. Here's Engine's hash in the logs git28f336b

Comment 10 Allon Mureinik 2018-02-14 13:43:54 UTC
(In reply to Leon Goldberg from comment #9)
> (In reply to Allon Mureinik from comment #6)
> > (In reply to Leon Goldberg from comment #4)
> > > Master.
> > Commit hash? Do you expect me to guess?
> 
> Precisely!
> 
> Which commit would you like to see? There is no single patch I can refer to.
> Here's Engine's hash in the logs git28f336b

That's a good start :-)
Thanks!

Comment 11 Allon Mureinik 2018-02-14 15:31:37 UTC
Eyal, I'm unable to reproduce this, but I wonder if your recent work may have affected this.
Please take a look?

Comment 12 Leon Goldberg 2018-02-15 10:10:01 UTC
(In reply to Allon Mureinik from comment #11)
> Eyal, I'm unable to reproduce this, but I wonder if your recent work may
> have affected this.
> Please take a look?

I'm not sure what you were trying to do but we managed to reproduce this via the UI very simply:

1) Take a snaphot
2) Edit a vNic's MAC address (probably irrelevant)
3) Restore the snapshot ---> fails with "Cannot preview Snapshot. Storage Domain doesn't exist."

Comment 13 Allon Mureinik 2018-02-15 11:34:49 UTC
Reproduced in the GUI, moving to Freddy for a quick relief.

Comment 14 Allon Mureinik 2018-02-15 12:22:20 UTC
Eyal - this was indeed a regression from adding the notion of vm leases to the snapshot.
Fred's attached patch fixes it, please make sure you take it too when you backport this work.

Comment 15 Eyal Shenitzky 2018-02-18 11:38:25 UTC
Sure, the fix was added to the patch backport.

Comment 16 Yaniv Kaul 2018-04-02 08:03:03 UTC
(In reply to Eyal Shenitzky from comment #15)
> Sure, the fix was added to the patch backport.

Was this backported? Which BZ / Gerrit?

Comment 17 Eyal Shenitzky 2018-04-02 08:28:26 UTC
Yes, this was backported as part of - https://gerrit.ovirt.org/#/c/87480/

Comment 18 Raz Tamir 2018-08-22 14:26:11 UTC
Are we planning to backport it to 4.2.z?

Comment 19 Eyal Shenitzky 2018-08-23 05:10:14 UTC
Already backported as mentioned in a comment #17.

Comment 20 Evelina Shames 2018-10-18 08:23:06 UTC
Verified.
Engine version: 4.2.7.3

Comment 21 Evelina Shames 2018-10-18 08:35:10 UTC
(In reply to Evelina Shames from comment #20)
> Verified.
> Engine version: 4.2.7.3

Sorry, Engine version: 4.3.0-0

Comment 22 Sandro Bonazzola 2018-11-02 14:33:37 UTC
This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 23 Sandro Bonazzola 2018-11-02 14:56:36 UTC
Closed by mistake, moving back to qa -> verified

Comment 24 Sandro Bonazzola 2019-02-13 07:48:09 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.