Bug 1545953

Summary:	Coverity uncovered several issues in pcsc-lite-ccid that should be addressed.
Product:	Red Hat Enterprise Linux 7	Reporter:	Bob Relyea <rrelyea>
Component:	pcsc-lite-ccid	Assignee:	Bob Relyea <rrelyea>
Status:	CLOSED ERRATA	QA Contact:	Asha Akkiangady <aakkiang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	rpattath
Target Milestone:	rc
Target Release:	7.6
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	pcsc-lite-ccid-1.4.10-14.el7	Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-30 11:35:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bob Relyea 2018-02-15 23:28:11 UTC

Buffer overflow:


line 98 src/towitoko/atr.c loop inside ATR_InitFromArray, we should check pn < 7 to prevent a buffer overflow if the ATR is malformed.

Concurrency:

line 414 of src/ifdhandler.c in CreateChannelByNameOrChannel. We return in an error case without freeing the lock or cleaning up.

CLANG: 

/src/ccid_usb.c:1043:14: warning: Result of 'calloc' is converted to a pointer of type 'unsigned int', which is incompatible with sizeof operand type 'int'

Comment 3 Bob Relyea 2018-05-23 20:46:13 UTC

fixed in pcsc-lite-ccid-1.4.10-14.el7

Comment 5 Roshni 2018-08-01 15:27:42 UTC

[root@dhcp129-188 ~]# rpm -qi pcsc-lite-ccid
Name        : pcsc-lite-ccid
Version     : 1.4.10
Release     : 14.el7
Architecture: x86_64
Install Date: Tue 31 Jul 2018 10:05:43 AM EDT
Group       : System Environment/Libraries
Size        : 562872
License     : LGPLv2+
Signature   : RSA/SHA256, Thu 21 Jun 2018 05:26:59 PM EDT, Key ID 199e2f91fd431d51
Source RPM  : pcsc-lite-ccid-1.4.10-14.el7.src.rpm
Build Date  : Wed 23 May 2018 04:52:23 PM EDT
Build Host  : x86-020.build.eng.bos.redhat.com
Relocations : (not relocatable)
Packager    : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla>
Vendor      : Red Hat, Inc.
URL         : http://pcsclite.alioth.debian.org/ccid.html
Summary     : Generic USB CCID smart card reader driver

Coverity scan passed on the errata with the above builds.

Comment 7 errata-xmlrpc 2018-10-30 11:35:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3256