Bug 1546544

This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Some issues:

- "%post engine -p /sbin/ldconfig" and similar should be removed: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
- rpmlint gives a lot of "unused-direct-shlib-dependency" warnings, these can be fixed by modifying the build flags: https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency
- There are several libraries in %{_libdir} without a proper soname. Are these plugins? If so, can they be moved to %{_libdir}/bear-factory? Files in %{_libdir} should not have unversioned sonames.
- The BuildConflict should be shortly explained in the spec file.

Martin, are you still working on this? Once you've fixed the issues above, I will continue reviewing the package.

Hi folks,

can I help with getting the renaming process done? 

I have an outstanding packaging request for the clang compilation database creation tool Bear, that is currently blocked by this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1565848).


Dan

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear-factory.spec

%changelog
* Fri Oct 12 2018 Martin Gansser <martinkg> - 0.7.0-0.21.20180825git2a78522
- Remove scriptlets
- Add -Wl,--as-needed" to avoid "unused-direct-shlib-dependency" warnings
- Remove subpackage engine to bear-engine

I have only uploaded the rpm SPEC file due compilation issues:

[ 12%] Building CXX object bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/code/accelerator_table.cpp.o
cd /home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf && /usr/bin/c++  -DBEAR_FACTORY_TEXT_DOMAIN_PATH=/usr/share/locale -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D__WXGTK__ -Dbear_editor_EXPORTS -I/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-engine/common/include -I/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/.. -isystem /usr/lib64/wx/include/gtk3-unicode-3.0 -isystem /usr/include/wx-3.0  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -pthread -fPIC   -Wall -std=c++11 -pedantic -Wmissing-field-initializers -Wuninitialized '-DBF_IMAGES_PATH="/usr/share/bear-factory/images"' -o CMakeFiles/bear-editor.dir/code/accelerator_table.cpp.o -c /home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp: In member function 'void bf::accelerator_table::on_key_pressed(wxKeyEvent&)':
/home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp:102:45: error: 'virtual bool wxEvtHandler::ProcessEvent(wxEvent&)' is inaccessible within this context
       m_event_handler.ProcessEvent( command );
                                             ^
In file included from /usr/include/wx-3.0/wx/window.h:18,
                 from /home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/../bf/accelerator_table.hpp:19,
                 from /home/martin/rpmbuild/BUILD/bear-2a785228d85997dc1682ee71899841528fa09c33/bear-factory/bear-editor/src/bf/code/accelerator_table.cpp:14:
/usr/include/wx-3.0/wx/event.h:3355:18: note: declared here
     virtual bool ProcessEvent(wxEvent& event);
                  ^~~~~~~~~~~~
make[2]: *** [bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/build.make:66: bear-factory/bear-editor/src/bf/CMakeFiles/bear-editor.dir/code/accelerator_table.cpp.o] Error 1

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear-factory.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/bear-factory-0.7.0-0.21.20180825git2a78522.fc29.src.rpm

%changelog
* Fri Oct 12 2018 Martin Gansser <martinkg> - 0.7.0-0.21.20180825git2a78522
- Remove scriptlets
- Add -Wl,--as-needed" to avoid "unused-direct-shlib-dependency" warnings
- Remove subpackage engine to bear-engine
- Disable the bear editor with -DBEAR_EDITORS_ENABLED=0

Issues:

> %package bear-engine
should be
> %package -n bear-engine

and
> Requires: %{name}-engine%{?_isa} = %{version}-%{release}
should be
> Requires: bear-engine%{?_isa} = %{version}-%{release}
because %name is bear-factory.

If you want to keep using a macro, you could do instead:
> %global srcname bear
and then use
> %package -n %{srcname}-engine
and
> Requires: %{srcname}-engine%{?_isa} = %{version}-%{release}

Whatever you prefer.


The packages are currently not installable due to the wrong sub-package naming. I'll continue the review when this is fixed.

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear-factory.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/bear-factory-0.7.0-0.22.20180825git2a78522.fc29.src.rpm

%changelog
* Fri Oct 12 2018 Martin Gansser <martinkg> - 0.7.0-0.22.20180825git2a78522
- Use global macro srcname bear

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Missing -p parameter for install invocations
- Some files do not have proper license headers
- Afaik, the package should not obsolete bear <= 0.7.0-0.21 because there was
  never a bear package (just the source package)


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated". 1919 files have
     unknown license. Detailed output of licensecheck in
     /home/thofmann/fedora/reviews/1546544-bear-factory/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bear-
     engine , bear-factory-devel , bear-factory-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: bear-factory-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
          bear-engine-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
          bear-factory-devel-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
          bear-factory-debugsource-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
          bear-factory-0.7.0-0.22.20180825git2a78522.fc28.src.rpm
bear-factory.x86_64: W: spelling-error %description -l en_US plee -> peel, pee, lee
bear-factory.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp, asap
bear-factory.x86_64: W: obsolete-not-provided bear
bear-factory.x86_64: E: no-binary
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/bf-animation-editor.desktop bf-animation-editor
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/bf-level-editor.desktop bf-level-editor
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/bf-model-editor.desktop bf-model-editor
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/desc2img.desktop desc2img
bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, pee, lee
bear-engine.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp, asap
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_audio.so libbear_audio.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_communication.so libbear_communication.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_debug.so libbear_debug.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_engine.so libbear_engine.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_expr.so libbear_expr.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_generic_items.so libbear_generic_items.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_gui.so libbear_gui.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_input.so libbear_input.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_net.so libbear_net.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_text_interface.so libbear_text_interface.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_time.so libbear_time.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_universe.so libbear_universe.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_visual.so libbear_visual.so
bear-factory.src: W: spelling-error %description -l en_US plee -> peel, pee, lee
bear-factory.src: W: spelling-error %description -l en_US asgp -> asp, gasp, asap
5 packages and 0 specfiles checked; 14 errors, 11 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
bear-factory-debugsource.x86_64: W: invalid-url URL: https://github.com/j-jorge/bear <urlopen error [Errno -2] Name or service not known>
bear-factory-devel.x86_64: W: invalid-url URL: https://github.com/j-jorge/bear <urlopen error [Errno -2] Name or service not known>
bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, pee, lee
bear-engine.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp, asap
bear-engine.x86_64: W: invalid-url URL: https://github.com/j-jorge/bear <urlopen error [Errno -2] Name or service not known>
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_audio.so libbear_audio.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_communication.so libbear_communication.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_debug.so libbear_debug.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_engine.so libbear_engine.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_expr.so libbear_expr.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_generic_items.so libbear_generic_items.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_gui.so libbear_gui.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_input.so libbear_input.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_net.so libbear_net.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_text_interface.so libbear_text_interface.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_time.so libbear_time.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_universe.so libbear_universe.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_visual.so libbear_visual.so
bear-factory.x86_64: W: spelling-error %description -l en_US plee -> peel, pee, lee
bear-factory.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp, asap
bear-factory.x86_64: W: invalid-url URL: https://github.com/j-jorge/bear <urlopen error [Errno -2] Name or service not known>
bear-factory.x86_64: W: obsolete-not-provided bear
bear-factory.x86_64: E: no-binary
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/bf-animation-editor.desktop bf-animation-editor
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/bf-level-editor.desktop bf-level-editor
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/bf-model-editor.desktop bf-model-editor
bear-factory.x86_64: W: desktopfile-without-binary /usr/share/applications/desc2img.desktop desc2img
4 packages and 0 specfiles checked; 14 errors, 13 warnings.



Requires
--------
bear-factory-debugsource (rpmlib, GLIBC filtered):

bear-factory-devel (rpmlib, GLIBC filtered):
    bear-engine(x86-64)
    cmake-filesystem

bear-engine (rpmlib, GLIBC filtered):
    libGL.so.1()(64bit)
    libGLU.so.1()(64bit)
    libSDL2-2.0.so.0()(64bit)
    libSDL2_mixer-2.0.so.0()(64bit)
    libbear_audio.so()(64bit)
    libbear_communication.so()(64bit)
    libbear_debug.so()(64bit)
    libbear_engine.so()(64bit)
    libbear_expr.so()(64bit)
    libbear_gui.so()(64bit)
    libbear_input.so()(64bit)
    libbear_net.so()(64bit)
    libbear_text_interface.so()(64bit)
    libbear_time.so()(64bit)
    libbear_universe.so()(64bit)
    libbear_visual.so()(64bit)
    libboost_filesystem.so.1.66.0()(64bit)
    libboost_regex.so.1.66.0()(64bit)
    libboost_system.so.1.66.0()(64bit)
    libboost_thread.so.1.66.0()(64bit)
    libc.so.6()(64bit)
    libclaw_application.so.1()(64bit)
    libclaw_dynamic_library.so.1()(64bit)
    libclaw_graphic.so.1()(64bit)
    libclaw_logger.so.1()(64bit)
    libclaw_net.so.1()(64bit)
    libclaw_tween.so.1()(64bit)
    libdl.so.2()(64bit)
    libfreetype.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libjpeg.so.62()(64bit)
    libm.so.6()(64bit)
    libpng16.so.16()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

bear-factory (rpmlib, GLIBC filtered):
    hicolor-icon-theme



Provides
--------
bear-factory-debugsource:
    bear-factory-debugsource
    bear-factory-debugsource(x86-64)

bear-factory-devel:
    bear-factory-devel
    bear-factory-devel(x86-64)
    cmake(bear)

bear-engine:
    bear-engine
    bear-engine(x86-64)
    libbear_audio.so()(64bit)
    libbear_communication.so()(64bit)
    libbear_debug.so()(64bit)
    libbear_engine.so()(64bit)
    libbear_expr.so()(64bit)
    libbear_generic_items.so()(64bit)
    libbear_gui.so()(64bit)
    libbear_input.so()(64bit)
    libbear_net.so()(64bit)
    libbear_text_interface.so()(64bit)
    libbear_time.so()(64bit)
    libbear_universe.so()(64bit)
    libbear_visual.so()(64bit)

bear-factory:
    application()
    application(bf-animation-editor.desktop)
    application(bf-level-editor.desktop)
    application(bf-model-editor.desktop)
    application(desc2img.desktop)
    bear-factory
    bear-factory(x86-64)
    mimehandler(application/x-bear-animation)
    mimehandler(application/x-bear-level)
    mimehandler(application/x-bear-model)
    mimehandler(application/x-bear-spritedesc)



Unversioned so-files
--------------------
bear-engine: /usr/lib64/libbear_audio.so
bear-engine: /usr/lib64/libbear_communication.so
bear-engine: /usr/lib64/libbear_debug.so
bear-engine: /usr/lib64/libbear_engine.so
bear-engine: /usr/lib64/libbear_expr.so
bear-engine: /usr/lib64/libbear_generic_items.so
bear-engine: /usr/lib64/libbear_gui.so
bear-engine: /usr/lib64/libbear_input.so
bear-engine: /usr/lib64/libbear_net.so
bear-engine: /usr/lib64/libbear_text_interface.so
bear-engine: /usr/lib64/libbear_time.so
bear-engine: /usr/lib64/libbear_universe.so
bear-engine: /usr/lib64/libbear_visual.so

Source checksums
----------------
https://github.com/j-jorge/bear/archive/2a785228d85997dc1682ee71899841528fa09c33/bear-factory-2a785228d85997dc1682ee71899841528fa09c33.tar.gz#/bear-factory-2a78522.tar.gz :
  CHECKSUM(SHA256) this package     : 1b174deb53e0231a9438e8a3b6ee379361bbeedfd8db288fa8f7504873f5709a
  CHECKSUM(SHA256) upstream package : 1b174deb53e0231a9438e8a3b6ee379361bbeedfd8db288fa8f7504873f5709a


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1546544
Buildroot used: fedora-28-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


APPROVED
Please fix the issues above for the final package.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/bear-factory

bear-factory-0.7.0-0.23.20180825git2a78522.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ff8885ffe2

bear-factory-0.7.0-0.23.20180825git2a78522.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-defcf97872

Thank you for renaming!

bear-factory-0.7.0-0.23.20180825git2a78522.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ff8885ffe2

bear-factory-0.7.0-0.23.20180825git2a78522.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-defcf97872

bear-factory-0.7.0-0.23.20180825git2a78522.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

bear-factory-0.7.0-0.23.20180825git2a78522.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.