Bug 1546558
| Summary: | lighttpd should depend on psmisc for logrotate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Anssi Johansson <rhbugs> |
| Component: | lighttpd | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel7 | CC: | gwync, matthias, rhbugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lighttpd-1.4.49-1.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-03-27 19:04:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
An alternative approach would be to add "ExecReload=/bin/kill -HUP $MAINPID" to /usr/lib/systemd/system/lighttpd.service. This would allow changing the lighttpd logrotate config to invoke "systemctl reload lighttpd.service" instead of killall. Disclaimer: https://www.freedesktop.org/software/systemd/man/systemd.service.html says "Note however that reloading a daemon by sending a signal (as with the example line above) is usually not a good choice, because this is an asynchronous operation and hence not suitable to order reloads of multiple services against each other. It is strongly recommended to set ExecReload= to a command that not only triggers a configuration reload of the daemon, but also synchronously waits for it to complete." lighttpd-1.4.48-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-c5863bfbf2 lighttpd-1.4.49-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2a3d51dc83 lighttpd-1.4.49-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2a3d51dc83 lighttpd-1.4.49-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: /etc/logrotate.d/lighttpd contains this: postrotate /usr/bin/killall -HUP lighttpd &>/dev/null || : endscript However, in this particular instance killall (provided by the psmisc package) was not installed. Consequently, postrotate script did not work as intended, leaving lighttpd to write to the old log file. Proposed fix: lighttpd should have a Requires of psmisc Version-Release number of selected component (if applicable): lighttpd-1.4.48-1.el7.x86_64 How reproducible: Always Steps to Reproduce: 1. install lighttpd 2. make sure psmisc is not installed 3. wait until logrotate does its thing (typically on Sunday morning) Actual results: -rw-r--r-- 1 lighttpd lighttpd 320914 Feb 18 16:48 access.log-20180218 -rw-r--r-- 1 lighttpd lighttpd 0 Feb 18 07:29 access.log Expected results: -rw-r--r-- 1 lighttpd lighttpd 302571 Feb 18 07:29 access.log-20180218 -rw-r--r-- 1 lighttpd lighttpd 18343 Feb 18 16:48 access.log Additional info: Installing psmisc and running "killall -HUP lighttpd" convinced lighttpd to start writing to the new log file.