Bug 1546656

Summary: [NMCI][abrt] [faf] NetworkManager: raise(): /usr/libexec/nm-iface-helper killed by 6
Product: Red Hat Enterprise Linux 7 Reporter: Vladimir Benes <vbenes>
Component: NetworkManagerAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.5CC: atragler, bgalvani, fgiudici, lrintel, rkhan, sukulkar, thaller
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: http://faf.lab.eng.brq.redhat.com/faf/reports/bthash/a89802d1bd5111508058e7a755ba9f7229727a94/
Whiteboard:
Fixed In Version: NetworkManager-1.12.0-0.1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 11:11:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
[patch] iface-helper: fix non-reentrant call to platform for failed IPv6 DAD none

Description Vladimir Benes 2018-02-19 09:26:43 UTC
This bug has been created based on an anonymous crash report requested by the package maintainer.

Report URL: http://faf.lab.eng.brq.redhat.com/faf/reports/bthash/a89802d1bd5111508058e7a755ba9f7229727a94/

Comment 2 Vladimir Benes 2018-02-19 09:27:14 UTC
present in PR67

Comment 3 Thomas Haller 2018-02-19 16:31:24 UTC
Created attachment 1397952 [details]
[patch] iface-helper: fix non-reentrant call to platform for failed IPv6 DAD

The bug is not only on https://github.com/NetworkManager/NetworkManager/pull/67, but on master for a long time (since before 1.2).

Please review.

Comment 4 Francesco Giudici 2018-02-20 12:20:37 UTC
patch lgtm.

A couple of cosmetic things I would consider changing...

- not really loving the names:
"m_ndisc_dad_addr_is_fail_candidate" & "m_ndisc_dad_addr_is_fail_candidate_event"

- why "addr2" instead of "addr" in nm_ndisc_dad_addr_is_fail_candidate() ?

Comment 5 Beniamino Galvani 2018-02-21 09:02:06 UTC
Patch LGTM.

Comment 8 Vladimir Benes 2018-08-17 10:31:09 UTC
We haven't seen this in 1.12. Moving to verified.

Comment 10 errata-xmlrpc 2018-10-30 11:11:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3207