Bug 1546675

Summary:	Guest IP addresses are not cleared when interfaces reporting is disabled from guest agent
Product:	[oVirt] ovirt-engine	Reporter:	Tomáš Golembiovský <tgolembi>
Component:	BLL.Network	Assignee:	Arik <ahadas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Michael Burman <mburman>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.2.1.4	CC:	ahadas, bugs, mburman, michal.skrivanek, pmatyas, ratamir, tgolembi
Target Milestone:	ovirt-4.3.0	Flags:	rule-engine: ovirt-4.3+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-13 07:48:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1437145

Description Tomáš Golembiovský 2018-02-19 10:19:35 UTC

Description of problem:

When guest agent stops reporting information for some interface the engine still caches the data and reports it to the user. The 'IP address' column in 'Virtual Machines' view is updated properly, but the 'Network' section and 'Guest Agent data' subsection in the VM details view still reports the original data. The data returned by REST API also report the old data

Is this the intended behaviour or a bug?

Note that we have an RFE for guest agent (bug 1437145) to disable reporting of specific network interfaces. When the disabled interface is eth0 engine still reports the data even though guest agent is not reporting it any more.

Comment 1 Michal Skrivanek 2018-02-20 06:05:48 UTC

It's intentional to cache IP. However we do not have to cache the whole interface and when it disappears the data should be cleared

Comment 2 Arik 2018-05-01 10:50:49 UTC

Tomas, was there any NIC keep being reported by the guest agent?

Comment 3 Tomáš Golembiovský 2018-05-14 14:39:36 UTC

I retested this and it seems the problem exists only when you blacklist all the NICs. As long as at least one NIC is reported from guest agent the cached data are cleared properly.

Comment 4 Arik 2018-05-14 14:48:50 UTC

In light of comment 3, this should be fixed on the master branch already.

Comment 5 Michael Burman 2018-08-20 13:04:18 UTC

Arik, i think that on VM shutdown the IP addresses should be returned to N/A as well.

Comment 6 Michael Burman 2018-08-20 13:16:08 UTC

Except the shutdown flow i think this can be verified.

When stopping the guest-agent(qemu/ovirt) on the VM, the IP addresses are gone from the column and from the network interfaces sub tab. which is ok.
But i truly believe that shut down VM should behave the same, if no guest agent is running, the IP address should be N/A on the network interface sub tab. 
Let me know what you think,

Tested on - 4.3.0-0.0.master.20180819104048.git932969e.el7

Comment 7 Arik 2018-08-20 13:45:40 UTC

(In reply to Michael Burman from comment #5)
> Arik, i think that on VM shutdown the IP addresses should be returned to N/A
> as well.

Well, could be but should be discussed separately.

Comment 8 Michael Burman 2018-08-21 07:23:16 UTC

Verified on - 4.3.0-0.0.master.20180819104048.git932969e.el7

For the shut down VM scenario i reported this - BZ 1619534
The same behavior should be when shutting down the VM

Comment 9 Sandro Bonazzola 2018-11-02 14:30:34 UTC

This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 10 Sandro Bonazzola 2018-11-02 14:57:06 UTC

Closed by mistake, moving back to qa -> verified

Comment 11 Sandro Bonazzola 2019-02-13 07:48:05 UTC

This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.