Bug 1546797

Summary:	python-firehose: python3-firehose requires both Python 2 and Python 3
Product:	[Fedora] Fedora	Reporter:	Iryna Shcherbina <ishcherb>
Component:	python-firehose	Assignee:	Dave Malcolm <dmalcolm>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	28	CC:	dmalcolm, jberan, mhroncok
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-firehose-0.5-3.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-30 13:16:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1285816, 1312032, 1340802

Description Iryna Shcherbina 2018-02-19 15:58:18 UTC

The python3-firehose (0.5-2.fc28) RPM requires both Python 2 and Python 3:

$  dnf --disablerepo=* --enablerepo=rawhide repoquery --requires python3-firehose | grep python
/usr/bin/python2
python(abi) = 3.6
...

This happened due to recently introduced shebangs mangling [0], and you might see the warnings in the build log:

> + /usr/lib/rpm/redhat/brp-mangle-shebangs
> *** WARNING: mangling shebang in ./usr/lib/python3.6/site-packages/firehose/parsers/gcc.py from #!/usr/bin/env python to #!/usr/bin/python2. This will become an ERROR, fix it manually!
> *** WARNING: mangling shebang in ./usr/lib/python3.6/site-packages/firehose/parsers/cppcheck.py from #!/usr/bin/env python to #!/usr/bin/python2. This will become an ERROR, fix it manually!


The executables contain `#!/usr/bin/env python` shebang, which is forbidden by the guidelines and is automatically mangled to `#!/usr/bin/python2` during build. Please fix the shebang to be `#!/usr/bin/python3` explicitly [1] or remove the executable bit from the above files if not needed.

If anything is unclear, or if you need any kind of assistance, you can
ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy
to help investigating or fixing this issue!

[0] https://pagure.io/packaging-committee/issue/738#comment-490366
[1] http://python-rpm-porting.readthedocs.io/en/latest/application-modules.html#fixing-shebangs

Comment 1 Fedora End Of Life 2018-02-20 15:35:57 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 2 Jan Beran 2018-03-23 07:23:47 UTC

Hi Dave,

I have created a PR that fixes the issue:

https://src.fedoraproject.org/rpms/python-firehose/pull-request/1

May I ask to review the PR and rebuild the package?

Comment 3 Dave Malcolm 2018-03-23 12:12:32 UTC

Thanks.  Merged.

Built into rawhide as https://koji.fedoraproject.org/koji/taskinfo?taskID=25902226

Comment 4 Miro Hrončok 2018-03-23 12:25:19 UTC

Please, also Fedora 28.

https://src.fedoraproject.org/rpms/python-firehose/pull-request/2

Comment 5 Dave Malcolm 2018-03-23 12:50:06 UTC

Built for Fedora 28 ("f28-candidate") here:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=25903252

Comment 6 Fedora Update System 2018-03-23 14:46:09 UTC

python-firehose-0.5-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-dc9b50f82f

Comment 7 Fedora Update System 2018-03-30 13:16:13 UTC

python-firehose-0.5-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.