Bug 1546957

Summary:	Get profiling status during the sync
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Nishanth Thomas <nthomas>
Component:	web-admin-tendrl-gluster-integration	Assignee:	Shubhendu Tripathi <shtripat>
Status:	CLOSED ERRATA	QA Contact:	Filip Balák <fbalak>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.4	CC:	amukherj, fbalak, mbukatov, nthomas, rhinduja, rhs-bugs
Target Milestone:	---
Target Release:	RHGS 3.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tendrl-ansible-1.6.1-2.el7rhgs.noarch.rpm, tendrl-api-1.6.1-1.el7rhgs.noarch.rpm, tendrl-commons-1.6.1-1.el7rhgs.noarch.rpm, tendrl-monitoring-integration-1.6.1-1.el7rhgs.noarch.rpm, tendrl-node-agent-1.6.1-1.el7, tendrl-ui-1.6.1-1.el7rhgs.noarch.rpm,	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-04 07:00:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1537357
Bug Blocks:	1503137

Description Nishanth Thomas 2018-02-20 07:00:30 UTC

From gluster 3.4 onwards there is going to a flag saying if profiling is enabled for a volume in get-state command output.
Backend needs to undergo changes to support this third option while import cluster. If this option selected during import cluster flow, the tendrl should retain the mixed profiling enabled state for the individual volumes and mark the cluster level profiling enabled information as mixed.

Also backend should be backward compatible which makes sure, even if we dont have get-state returning profile info a volume level, leave the cluster as is and don't mark for individual volumes.

Comment 2 Shubhendu Tripathi 2018-03-05 02:32:25 UTC

Now while state sync in tendrl-gluster-integration, the volume specific profiling flag would be considered and accordingly cluster level value would be set. Now while import cluster, there are three options namely Enable Volume Profiling, Disable Volume Profiling, retain as is. 

If user selects Enable volume proifling, during state sync for all the volumes profiling would get enabled (even if for few it was already enabled they would be left as is and for rest of the volumes profiling would be enabled).

If user selects Disable Volume profiling option while import cluster, even if few volumes have it enabled during state sync for all the volumes profiling would be disabled.

If use opts for retaining volume profiling as is while import cluster, individual volume level values are retained and based on that cluster level value is set Enabled (if for all volumes underlying profiling is enable), Disabled (if for all underlying volumes profiling is disabled) or mixed (if for few volumes profiling is enabled and for few its disabled).

Also volume level profiling can now be enabled/disabled with actions available now.

Comment 3 Shubhendu Tripathi 2018-03-05 02:32:51 UTC

Now while state sync in tendrl-gluster-integration, the volume specific profiling flag would be considered and accordingly cluster level value would be set. Now while import cluster, there are three options namely Enable Volume Profiling, Disable Volume Profiling, retain as is. 

If user selects Enable volume proifiling, during state sync for all the volumes profiling would get enabled (even if for few it was already enabled they would be left as is and for rest of the volumes profiling would be enabled).

If user selects Disable Volume profiling option while import cluster, even if few volumes have it enabled during state sync for all the volumes profiling would be disabled.

If use opts for retaining volume profiling as is while import cluster, individual volume level values are retained and based on that cluster level value is set Enabled (if for all volumes underlying profiling is enable), Disabled (if for all underlying volumes profiling is disabled) or mixed (if for few volumes profiling is enabled and for few its disabled).

Also volume level profiling can now be enabled/disabled with actions available now.

Comment 4 Martin Bukatovic 2018-04-04 07:50:55 UTC

The BZ seems to block some gluster BZ, but this looks like an
error and it should be vice versa. Could you check and fix it if needed?

Comment 7 Filip Balák 2018-05-17 08:47:51 UTC

Profiling seems to be correctly set on cluster and on volume level.
--> VERIFIED

Tested with:
tendrl-ansible-1.6.3-3.el7rhgs.noarch
tendrl-api-1.6.3-3.el7rhgs.noarch
tendrl-api-httpd-1.6.3-3.el7rhgs.noarch
tendrl-commons-1.6.3-4.el7rhgs.noarch
tendrl-gluster-integration-1.6.3-2.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-2.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-2.el7rhgs.noarch
tendrl-node-agent-1.6.3-4.el7rhgs.noarch
tendrl-notifier-1.6.3-2.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-1.el7rhgs.noarch
glusterfs-3.12.2-10.el7rhgs.x86_64

Comment 9 errata-xmlrpc 2018-09-04 07:00:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616