Bug 1547454
| Summary: | rpm: brp-strip-static-archive ignores exit status from strip | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> | ||||
| Component: | rpm | Assignee: | Packaging Maintenance Team <packaging-team-maint> | ||||
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 29 | CC: | igor.raits, mjw, packaging-team-maint, pmatilai, pmoravco, vmukhame | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1547457 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-11-27 19:03:46 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1547457 | ||||||
| Attachments: |
|
||||||
|
Description
Florian Weimer
2018-02-21 11:17:16 UTC
You proposed patch adds set -e to brp-strip, brp-strip-comment-note, brp-strip-shared and brp-strip-static-archive. I think it does what you want for brp-strip-shared and brp-strip-static-archive. But brp-strip and brp-strip-comment-note invoke strip with $STRIP ... || : So I believe it doesn't have any effect on those. Should the || : be removed too? (In reply to Mark Wielaard from comment #1) > You proposed patch adds set -e to brp-strip, brp-strip-comment-note, > brp-strip-shared and brp-strip-static-archive. > > I think it does what you want for brp-strip-shared and > brp-strip-static-archive. But brp-strip and brp-strip-comment-note invoke > strip with $STRIP ... || : > So I believe it doesn't have any effect on those. > > Should the || : be removed too? Oh, right, I agree. Should I send an updated patch? (In reply to Florian Weimer from comment #2) > Oh, right, I agree. Should I send an updated patch? Please also to rpm-maint.org since this isn't a Fedora only issue. Or is it? This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle. Changing version to '29'. This message is a reminder that Fedora 29 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '29'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 29 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |