Bug 1547540

Summary: cdparanoia: Overrides Fedora build flags
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: cdparanoiaAssignee: Peter Jones <pjones>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ajax, pjones
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cdparanoia-10.2-27.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-05 11:48:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1539083    

Description Florian Weimer 2018-02-21 14:07:59 UTC
The spec file currently contains this:

%configure --includedir=%{_includedir}/cdda
# Using -O0 is mandatory, the build fails otherwise...
# Also remove many warnings which we are aware of
# Lastly, don't use _smp_mflags since it also makes the build fail
make OPT="$RPM_OPT_FLAGS -O0 -Wno-pointer-sign -Wno-unused"

-O0 does not appear to be necessary, but LDFLAGS injection is only partially successful.  The libraries aren't linked properly:

gcc -fpic -shared -o libcdda_interface.so.0.10.2 -Wl,-soname -Wl,libcdda_interface.so.0 scan_devices.o	common_interface.o cooked_interface.o interface.o scsi_interface.o smallft.o toc.o test_interface.o -lm -lrt

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Adam Jackson 2018-03-07 18:25:05 UTC
Fixed in git.

Comment 2 Florian Weimer 2018-03-19 17:22:38 UTC
Would you mind putting this into Fedora 28 as well?  Thanks.

Comment 3 Fedora Update System 2018-04-02 18:00:42 UTC
cdparanoia-10.2-27.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3fc8eba5cc

Comment 4 Fedora Update System 2018-04-03 15:57:48 UTC
cdparanoia-10.2-27.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3fc8eba5cc

Comment 5 Fedora Update System 2018-04-05 11:48:17 UTC
cdparanoia-10.2-27.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.