Bug 1547991

Summary:	[DR] [BLOCKED on bug 1524455 ] VM lease ignored when registering a VM from a data domain
Product:	[oVirt] ovirt-engine	Reporter:	Eyal Shenitzky <eshenitz>
Component:	BLL.Storage	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.3.0	CC:	amureini, bugs, ebenahar, eshenitz, tnisan, ylavi
Target Milestone:	ovirt-4.2.2	Keywords:	Reopened
Target Release:	---	Flags:	rule-engine: ovirt-4.2+ rule-engine: blocker+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-29 10:54:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1524455
Bug Blocks:

Description Eyal Shenitzky 2018-02-22 13:50:33 UTC

Description of problem:

When registering a VM with a lease from a data domain, the VM registered to the data-center but the VM lease doesn't create.
The VM appeared to be with the lease but the lease doesn't exist.


Version-Release number of selected component (if applicable):
master-4.3.0 - from commit 2b737f5ee74668ab201aec7c118444382e2f6365

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with disk and lease based on storage domain 'A'
2. Deactivate and detach storage domain 'A'
3. Attach storage domain 'A' back to the data-center
4. register the VM from step 1

Actual results:
VM registered back to the data-center,
The VM appeared to have a lease, but the lease doesn't exist.

Expected results:
VM should be registered and the lease should create on one of the storage domains

Additional info:

Comment 1 Eyal Shenitzky 2018-03-13 06:33:10 UTC


*** This bug has been marked as a duplicate of bug 1524455 ***

Comment 2 Allon Mureinik 2018-03-13 07:52:48 UTC

(In reply to Eyal Shenitzky from comment #1)
> 
> *** This bug has been marked as a duplicate of bug 1524455 ***

Eyal, this bug is about registering a VM from a *data* domain, while bug 1524455 is about importing from an *export* domain.
Can you explain where the code paths converge?

Comment 3 Eyal Shenitzky 2018-03-13 08:10:06 UTC

The fix for bug 1524455 should also solve the issue above (https://gerrit.ovirt.org/#/c/88314).
should I set the bug to be dependent on bug 1524455 instead of closing it?

Comment 4 Allon Mureinik 2018-03-13 08:13:21 UTC

(In reply to Eyal Shenitzky from comment #3)
> The fix for bug 1524455 should also solve the issue above
> (https://gerrit.ovirt.org/#/c/88314).
> should I set the bug to be dependent on bug 1524455 instead of closing it?

I think so.
The usecase here is different, and QE should verify both flows (regardless of whether the same patch solves both issues)

Comment 5 Kevin Alon Goldblatt 2018-03-27 16:04:04 UTC

Verified with the following code:
------------------------------------------
ovirt-engine-4.2.2.5-0.1.el7.noarch
vdsm-4.20.23-1.el7ev.x86_64\

Verified with the following scenario:
------------------------------------------
Steps to Reproduce:
1. Create a VM with disk and lease based on storage domain 'A'
2. Deactivate and detach storage domain 'A'
3. Attach storage domain 'A' back to the data-center
4. register the VM from step 1


Expected results:
VM is registered and the lease exists on the storage domain

Moving to verified

Comment 6 Sandro Bonazzola 2018-03-29 10:54:54 UTC

This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.