Bug 1548536
| Summary: | hivex: Partial injection of Fedora build flags | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | hivex | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 28 | CC: | jen, rjones |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | hivex-1.3.15-3.fc29 hivex-1.3.15-3.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-10 22:54:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1539083 | ||
|
Description
Florian Weimer
2018-02-23 19:26:36 UTC
/usr/lib64/ocaml/stublibs/dllmlhivex.so are the C part of the OCaml bindings for hivex. They are automatically generated and just shuffle parameters from the OCaml side to the C side and back. It's not likely that there's any real need to use hardening here as OCaml isn't subject to the usual problems that afflict C code. Anyway I'll see if there's some way to inject the flags into the ocamlmklib command which generates this file. Fixed in hivex-1.3.15-3.fc29 Or it would be fixed, but the fix breaks strip: + /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip /usr/bin/strip:/home/rjones/rpmbuild/BUILDROOT/hivex-1.3.15-3.fc29.x86_64/usr/lib64/ocaml/hivex/libmlhivex.a(hivex_c.o)[.gnu.build.attributes]: corrupt GNU build attribute note: bad description size: Bad value /usr/bin/strip:/home/rjones/rpmbuild/BUILDROOT/hivex-1.3.15-3.fc29.x86_64/usr/lib64/libhivex.a(libhivex_la-handle.o)[.gnu.build.attributes]: corrupt GNU build attribute note: bad description size: Bad value Turns out whatever the problem is with strip it doesn't affect Rawhide. Would you please bring this change into Fedora 28 as well? Thanks. hivex-1.3.15-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-64a05f528d hivex-1.3.15-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-64a05f528d hivex-1.3.15-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |