Bug 1548669
| Summary: | tcp_wrappers: Partial build flags injection | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | tcp_wrappers | Assignee: | Jakub Jelen <jjelen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fweimer, jjelen, plautrba |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | tcp_wrappers-7.6-89.fc29 tcp_wrappers-7.6-91.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-07 22:13:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1539083 | ||
|
Description
Florian Weimer
2018-02-24 10:31:01 UTC
Are you saying that just the LDFLAGS are missing in the above snippet? Or they are missing also in other places? Or something else is missing from other places? Is there some way how I can check the changes I will do resolved the reported issue? There is already ldflags patch, that adds LDFLAGS to all the other occurrences. If I add LDFLAGS to that line and adjust it in the spec file, I am able to build shared library in this form: gcc -shared -fPIC -Wl,-soname -Wl,libwrap.so.0 \ -o libwrap.so.0.7.6 hosts_access.o options.o shell_cmd.o rfc931.o eval.o hosts_ctl.o refuse.o percent_x.o clean_exit.o weak_symbols.o fromhost.o fix_options.o socket.o tli.o workarounds.o update.o misc.o diag.o percent_m.o myvsyslog.o -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -lnsl Is it sufficient or is there anything more to do? I will build the package after review. Thanks. (In reply to Jakub Jelen from comment #2) > There is already ldflags patch, that adds LDFLAGS to all the other > occurrences. If I add LDFLAGS to that line and adjust it in the spec file, I > am able to build shared library in this form: > > gcc -shared -fPIC -Wl,-soname -Wl,libwrap.so.0 \ > -o libwrap.so.0.7.6 hosts_access.o options.o shell_cmd.o rfc931.o eval.o > hosts_ctl.o refuse.o percent_x.o clean_exit.o weak_symbols.o fromhost.o > fix_options.o socket.o tli.o workarounds.o update.o misc.o diag.o > percent_m.o myvsyslog.o -Wl,-z,relro -Wl,-z,now > -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -lnsl > > Is it sufficient or is there anything more to do? I will build the package > after review. Thanks. Yes, commit 75a86a6d6d5daed5f653a61364c13ddbf00cb918 looks reasonable. I will have a look at the build, too, once it finishes. The rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25556560 tcp_wrappers-7.6-90.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-109321c535 tcp_wrappers-7.6-90.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-109321c535 tcp_wrappers-7.6-91.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-109321c535 tcp_wrappers-7.6-91.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |