Bug 1548754

Summary:	xorg-x11-utils: Incorrect build flags used for edid-decode
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	xorg-x11-utils	Assignee:	X/OpenGL Maintenance List <xgl-maint>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ajax, fweimer, jglisse, negativo17, xgl-maint
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	xorg-x11-utils-7.5-27.fc28 xorg-x11-utils-7.5-28.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-05 11:48:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1539083

Description Florian Weimer 2018-02-24 19:20:35 UTC

The makefile has this:

edid-decode: edid-decode.c
	$(CC) -g -Wall -o $@ $<

So the CFLAGS/LDFLAGS are ignored.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Adam Jackson 2018-03-07 16:04:05 UTC

Fixed in the upstream makefile, built a new snapshot in xorg-x11-utils-7.5-27.fc28

Comment 2 Florian Weimer 2018-03-19 17:21:37 UTC

Would you please put this into Fedora 28 as well?

Comment 3 Fedora Update System 2018-04-02 19:02:25 UTC

xorg-x11-utils-7.5-28.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-aaa5020a20

Comment 4 Fedora Update System 2018-04-03 15:57:54 UTC

xorg-x11-utils-7.5-28.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-aaa5020a20

Comment 5 Fedora Update System 2018-04-05 11:48:24 UTC

xorg-x11-utils-7.5-28.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Florian Weimer 2018-04-09 11:20:02 UTC

My automated testing says that this was fixed properly, and now also verified manually.  Thanks.