Bug 1549671

Summary: Check for module skipping in accounts_passwords_pam_faillock_deny is tricked by comment in config file
Product: Red Hat Enterprise Linux 7 Reporter: Watson Yuuma Sato <wsato>
Component: scap-security-guideAssignee: Watson Yuuma Sato <wsato>
Status: CLOSED ERRATA QA Contact: Vojtech Polasek <vpolasek>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.5CC: mhaicman, openscap-maint, vpolasek
Target Milestone: rcFlags: lcervako: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: scap-security-guide-0.1.49-1.el7 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1761906 (view as bug list) Environment:
Last Closed: 2020-09-29 19:52:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1761906    
Attachments:
Description Flags
logs from ansible remediations
none
logs from bash remediation none

Description Watson Yuuma Sato 2018-02-27 15:43:43 UTC 
Description of problem:
OVAL definition for rule accounts_passwords_pam_faillock_deny verifies if number of modules skipped by pam_unix.so goes beyond pam_faillock.so authfail in the stack.
This definition returns false negatives in case there is a comment with string "pam_unix" before the actual pam_unix.so module in the stack.


Version-Release number of selected component (if applicable):
0.1.37

How reproducible:
always


Steps to Reproduce:
1. Run SSG Test Suite for pam_faillock_deny
2.
3.

Actual results:

INFO - xccdf_org.ssgproject.content_rule_accounts_passwords_pam_faillock_deny
ERROR - Script skip_longer.fail.sh using profile xccdf_org.ssgproject.content_profile_C2S found issue:
ERROR - Scan has exited with return code 0, instead of expected 2 during stage initial
ERROR - The initial scan failed for rule 'xccdf_org.ssgproject.content_rule_accounts_passwords_pam_faillock_deny'.

Test scenario skip_longer.fail.sh passes.

Expected results:
Test scenario skip_longer.fail.sh should fail.

Additional info:
Comment 5 Vojtech Polasek 2020-02-05 13:28:21 UTC 
Fixed upstream in https://github.com/ComplianceAsCode/content/pull/5166
Comment 9 Vojtech Polasek 2020-03-27 16:22:38 UTC 
Created attachment 1674114 [details]
logs from ansible remediations
Comment 10 Vojtech Polasek 2020-03-27 16:26:01 UTC 
Created attachment 1674115 [details]
logs from bash remediation
Comment 12 errata-xmlrpc 2020-09-29 19:52:12 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (scap-security-guide bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3909