Bug 1549686 (f28-backgrounds)
Summary: | Review Request: f28-backgrounds - Fedora 28 default desktop background | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luya Tshimbalanga <luya> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | awilliam, gmarr, luya, package-review, rdieter, robatino, zebob.m |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | AcceptedBlocker | ||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-03-12 22:36:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1469204 |
Description
Luya Tshimbalanga
2018-02-27 16:21:12 UTC
- https://fedoraproject.org/wiki/F28_Artwork is empty - [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/backgrounds/f28/extras, /usr/share/wallpapers, /usr/share/backgrounds/f28, /usr/share/gnome-background-properties, /usr/share/mate-background-properties, /usr/share/xfce4, /usr/share/xfce4/backdrops Check out whether you own these directories correctly. I think one that should be owned in the extras subpackage is: %dir %{_datadir}/backgrounds/%{bgname}/extras I can review today fyi, embedded metadata.desktop for the kde wallpaper still says Twenty-Seven/f27, but I can help fix that post review so that it's more future proof (ie, will minimize or remove any need for manual editing for future releases). first off: (more thorough items coming soon) 1. file ownership referenced in comment #1 %files extras-base ... %{_datadir}/backgrounds/%{bgname}/extras/*.jpg %{_datadir}/backgrounds/%{bgname}/extras/*.png %{_datadir}/backgrounds/%{bgname}/extras/%{bgname}-extras.xml could be replaced by simple: %{_datadir}/backgrounds/%{bgname}/extras/ or add %dir %{_datadir}/backgrounds/%{bgname}/extras/ /usr/share/wallpapers is already owned by kde-filesystem /usr/share/backgrounds/f28 is owned by -base subpkg For /usr/share/xfce4/backdrops, I think those should be added here (I don't see anything else better to provide ownership) %files xfce %dir %{_datadir}/xfce4/ %dir %{_datadir}/xfce4/backdrops/ Same for /usr/share/gnome-background-properties, add to %files gnome ... %dir %{_datadir}/gnome-background-properties/ Same for -mate, %files mate ... %dir %{_datadir}/mate-background-properties/ Thanks Robert-André and Rex. Here is the updated spec and srpm based on feedback: SPECS: https://copr-be.cloud.fedoraproject.org/results/luya/f28-backgrounds/fedora-rawhide-x86_64/00722063-f28-backgrounds/f28-backgrounds.spec SRPMS: https://copr-be.cloud.fedoraproject.org/results/luya/f28-backgrounds/fedora-rawhide-x86_64/00722063-f28-backgrounds/f28-backgrounds-28.1.0-1.fc28.noarch.rpm Quick follow-up: I realize the deadline for packaging the default wallpaper is on March 5. Due to job related, I will be unable to update during weekday until evening Pacific time due to lack of access to my laptop. Thanks, looks good, the rest if fairly simple, clean, and templated from prior release packages in general. APPROVED (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/f28-backgrounds Excellent. (In reply to Rex Dieter from comment #3) > fyi, embedded metadata.desktop for the kde wallpaper still says > Twenty-Seven/f27, but I can help fix that post review so that it's more > future proof (ie, will minimize or remove any need for manual editing for > future releases). I took opportunity to quickly fix the versionin on metadata.desktop. Feel free to further bring enhancement. Proposed as a Blocker for 28-beta by Fedora user luya using the blocker tracking app because: Default beta wallpapers for Fedora 28 is recently packaged for the beta release that just got frozen. The release criterion here states "The default desktop background must be different from that of the last two stable releases." Without this update, is the F28 background the same as the F26 or F27 backgrounds? If so, this is a blocker, if not, FE. (In reply to Adam Williamson from comment #11) > is the F28 background the same as the F26 or F27 backgrounds? If so, this is > a blocker, if not, FE. In this case, F28 backgrounds differ from the previous release so assigning to FE. desktop-backgrounds-28.0.0-1.fc28, f28-backgrounds-28.1.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f86f6e9857 Luya: the question isn't whether the *new* backgrounds are different, of course they are. The question is whether the backgrounds *currently* in F28 - before this update - are the same as F27 or F26. And it looks to me like they're the same as F27: https://openqa.fedoraproject.org/tests/200929#step/_do_install_and_reboot/31 which would make this a blocker. Discussed during the 2018-03-12 blocker review meeting: [1] The decision to classify this bug as an AcceptedBlocker was made as it violates the following blocker criteria: "The default desktop background must be different from that of the last two stable releases" [1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2018-03-12/f28-blocker-review.2018-03-12-16.01.txt desktop-backgrounds-28.0.0-1.fc28, f28-backgrounds-28.1.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |